Repository navigation
feat: Let the Actor store provide proxied Actor picture URLs - #1467
Merged
Merged
Conversation
commit: |
MQ37
marked this pull request as ready for review
September 30, 2026 21:14
jirispilka
reviewed
Oct 1, 2026
jirispilka
left a comment
Collaborator
There was a problem hiding this comment.
I want have time to test it myself, so I don't want to block this.
I posted a comment here, relevant also for this PR: https://github.com/apify/apify-mcp-server-internal/pull/807#issuecomment-5941910021
vojtechj-apify
approved these changes
Oct 13, 2026
vojtechj-apify
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Minor, to check: getProxiedPictureUrl runs inside the try in fetchActorDetails, whose catch rethrows non-404/400 errors, so a throwing signer would fail the whole fetch-actor-details call over an avatar URL. Unlikely with the current HMAC signer; not blocking.
Generated by Claude Code
MQ37
force-pushed
the
feat/actor-store-proxied-picture-url
branch
from
October 19, 2026 16:31
bc69551 to
85cd683
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part of #804.
fetch-actor-detailsgets the Actor picture from the Store search (resized imgproxy URL) because the raw S3 URL from the Apify API has no CORS headers and breaks the widget avatar (#459). That costs an extra request per call and does not work for private or unlisted Actors. The hosted server can sign the same URL itself.What changed
fetchActorDetailsalways searched the Store for the picture URL.ActorStorehas an optionalgetProxiedPictureUrl(). If the host provides it, the search is skipped and its URL is used. Without it (stdio) nothing changes.fetchActorDetailstakes{ cardOptions, actorStore }to stay at 3 positional params (not exported from./internals).Notes for reviewers (human-written)
actorStorealready reaches every tool.image/pnghard-coded). Supersedes fix: Drop redundant store-search call in fetchActorDetails #1377.Proof it works
Internal server with this build, container, real api.apify.com:
Same for web-scraper and rag-web-browser. No
/v2/storecall on the hosted path, one in the stdio fallback.