Repository navigation
Conversation
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves
toSafeResourceId,isAmbiguousResourceId, andgetResourceByIdOrNamefromsrc/tools/tasks/task_helpers.tsto a new module,src/utils/apify_resource_id.ts. No behavior change.Why
These helpers already resolve tasks, schedules, and Actors, so they don't belong in the task helpers. The source tools (#1453) need the same resolution for their
actorargument. The repo lands a refactor before the feature that uses it, so the move comes in its own PR.Part of #1463.
How
toSafeResourceIdandisAmbiguousResourceIddocstrings no longer mention tasks only: they apply to any Apify resource the API addresses by ID or name (Actors, tasks, schedules, ...).task_helpers.tskeepsgetTaskByIdOrName, the task schemas, the task result shape, and the publication call, and imports the helpers from the new module.src/tools/AGENTS.mdpoints to the new location.Testing
type-check,lint,format,test:unit, andcheck:agentspass. No test imported these functions directly, so no test changed.AI disclosure: implemented with Claude Code; awaiting human review.
🤖 Generated with Claude Code