Repository navigation
feat(http): add an ignoreTlsErrors option to FileDownload - #4362
Open
vladfrangu wants to merge 2 commits into
Open
vladfrangu wants to merge 2 commits into
vladfrangu wants to merge 2 commits into
Conversation
FileDownload verifies TLS certificates by default and still honours session.proxyInfo.ignoreTlsErrors for MITM proxies. The new option is forwarded to the HTTP client the same way HttpCrawler does it. Related: #4240
github-actions
Bot
added
the
t-tooling
vladfrangu
changed the title
vladfrangu
marked this pull request as ready for review
November 6, 2026 16:41
janbuchar
self-requested a review
November 9, 2026 09:18
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileDownloadverifies TLS certificates by default and had no way to opt out short of building an impit client by hand. It now takesignoreTlsErrors(defaultfalse) in a reintroducedFileDownloadOptionstype and forwards it to the HTTP client the same wayHttpCrawlerdoes; MITM proxy sessions keep working throughsession.proxyInfo.ignoreTlsErrors. The upgrade guide describes the option instead of the impit workaround.Closes #4240.
[🤖] Claude Code using Fable 5.1
Stack created with GitHub Stacks CLI • Give Feedback 💬