Repository navigation
fix(utils): hash raw sitemap content once per source, not per url - #4381
Merged
Merged
Conversation
parseSitemap built the `raw://<sha256>` originSitemapUrl inside the per-entry
loop, so for a raw source (Sitemap.fromXmlString, or parseSitemap with
`{ type: 'raw' }`) the whole document was hashed again for every <url>. The
cost was O(urls x size): a 4.2 MB sitemap with 22k URLs took ~42 s of CPU to
parse, versus ~0.2 s with the hash computed once per source.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
the
t-tooling
barjin
self-requested a review
November 11, 2026 12:57
barjin
pushed a commit
that referenced
this pull request
Nov 11, 2026
) Backport of #4381 to 3.x. parseSitemap computes the raw://<sha256> originSitemapUrl inside the per-entry loop. For a raw source (Sitemap.fromXmlString(), or parseSitemap with { type: 'raw' }), it hashes the whole document again for every <url>, so parsing costs O(urls × size). We hit this with a real 4.2 MB sitemap with 22k URLs: parsing it from a string took ~42 s of CPU, versus ~0.3 s when crawlee fetches the same sitemap by URL. With the hash computed once per source, parsing the string takes ~0.2 s. The output is unchanged, since the value is identical for every entry of a source. I've used AI to create this fix and generate the above text, but manually checked both code and texts. --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseSitemap computes the raw:// originSitemapUrl inside the per-entry loop. For a raw source (Sitemap.fromXmlString(), or parseSitemap with { type: 'raw' }), it hashes the whole document again for every , so parsing costs O(urls × size).
We hit this with a real 4.2 MB sitemap with 22k URLs: parsing it from a string took ~42 s of CPU, versus ~0.3 s when crawlee fetches the same sitemap by URL. With the hash computed once per source, parsing the string takes ~0.2 s. The output is unchanged, since the value is identical for every entry of a source.
I've used AI to create this fix and generate the above text, but manually checked both code and texts.