Skip to content

docs: fix typos in TimeInput comments and Welcome story #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Avicennasis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: fix typos in TimeInput comments and Welcome story #1350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .storybook/stories/Welcome.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export const HelpAndContributing = () => (
<a href="https://github.com/appfolio/react-gears/issues">GitHub issue</a>
</p>
<p>
For the component roadmap, status, and ideas, please the{' '}
For the component roadmap, status, and ideas, please see the{' '}
<a href="https://github.com/appfolio/react-gears/projects/1">GitHub project board</a>
</p>
</section>
Expand Down
6 changes: 3 additions & 3 deletions src/components/Input/TimeInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,18 +173,18 @@ export default class TimeInput extends React.Component {
return false;
}

// only show times on step if we havent started to type minutes
// only show times on step if we haven't started to type minutes
if (!hasTypedTens && !onInterval(time, step)) {
return false;
}

// only show times on step or on 10 min intervals if we havent finished typing minutes
// only show times on step or on 10 min intervals if we haven't finished typing minutes
if (!hasTypedMin && !onInterval(time, step) && !onInterval(time, 10)) {
return false;
}

const labelCandidate = flow(
// Remove colon from option if input doesnt have one
// Remove colon from option if input doesn't have one
(str) => (inputCandidate.includes(':') ? str : str.replace(/:/gi, '')),
removeWhitespace,
removeLeadingZeros,
Expand Down