Repository navigation
fix: accept a content type with parameters like charset for the access token response - #27
Merged
Merged
Conversation
dsimons70
marked this pull request as ready for review
October 19, 2026 14:21
dsimons70
enabled auto-merge
October 19, 2026 14:28
chriskapp
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ClientCredentialsDecoratorcompared theContent-Typeof the access token response exactly withapplication/json. Authorization servers that add a parameter, e.g. Ivalua withapplication/json;charset=UTF-8, were rejected with "Content type should be: application/json", although it is the same media type (RFC 9110, 8.3). Every request through the decorator failed before it was sent.Content-Typeholds a single value, so it is read once viagetHeaderLine().s%instead of the status code.send()passes the client options to the access token request as well (timeout, proxy, TLS were ignored for it).ClientCredentialsDecoratorTest: content types with and without parameters, credentials in the body and withstrictRfcin the authorization header, client options for the token request, failed token request. The test lives next to the other OAuth2 tests intests/Unit/Client/OAuth2/.Needed for artemeon/core-ng#35619 (Ivalua client), to be released as 1.1.3.