Skip to content

Bump bonjour-service from 1.3.0 to 1.4.0 in /apps/desktop#343

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/apps/desktop/bonjour-service-1.4.0
Open

Bump bonjour-service from 1.3.0 to 1.4.0 in /apps/desktop#343
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/apps/desktop/bonjour-service-1.4.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github May 23, 2026

Bumps bonjour-service from 1.3.0 to 1.4.0.

Release notes

Sourced from bonjour-service's releases.

1.4.0

What's Changed

New Contributors

Full Changelog: onlxltd/bonjour-service@1.3.0...1.4.0

Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels May 23, 2026
@dependabot dependabot Bot requested a review from arul28 as a code owner May 23, 2026 02:23
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels May 23, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
ade Ignored Ignored Preview May 31, 2026 12:07am

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 23, 2026

PR author is in the excluded authors list.

@capy-ai
Copy link
Copy Markdown

capy-ai Bot commented May 23, 2026

Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews.

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

Scope: 2 file(s), +5 / −5
Verdict: Needs changes

Dependabot bumps bonjour-service from 1.3.0 to 1.4.0 in apps/desktop only (lockfile + package.json). No application source changes. The blocker is that 1.4.0 changes the package's TypeScript export shape, which breaks the existing named type imports in LAN runtime discovery code and will fail the typecheck-desktop CI job.


🐛 Functionality

[High] bonjour-service@1.4.0 breaks desktop typecheck

File: apps/desktop/src/main/services/remoteRuntime/runtimeDiscovery.ts:L6-L7,L267,L269
Issue: Version 1.4.0 ships export = Bonjour with Service and Browser exposed as namespace values, not type-only exports. The existing import { …, type Browser, type Service as BonjourService } from "bonjour-service" then fails tsc with TS2749 ("refers to a value, but is being used as a type") on the BonjourServiceLike, Browser, and event-handler parameter types.
Repro: On the PR branch, run cd apps/desktop && npm ci && npm run typecheck — three errors in runtimeDiscovery.ts (verified locally against 1.4.0; clean with 1.3.0).
Fix: Either adjust imports to match 1.4.0's typings (e.g. import Bonjour, { Service, Browser } from "bonjour-service" and use import type / InstanceType<typeof Service> as needed), or pin at 1.3.0 until call sites are updated. apps/desktop/package.json:L84 is the version line that triggers the break.


Notes

  • Positive: 1.4.0 adds browser srv-update, TTL/lastSeen tracking, and a publish-side fix for _services._dns-sd._udp browsing (#67). Desktop only browses _ade-sync._tcp in discoverLanRuntimes, so the publish fix mainly matters if apps/ade-cli is bumped too (it still pins ^1.3.0).
  • Security / dependency: Same MIT package and maintainer; no new trust boundary in this diff. mDNS TXT is already normalized in discoveredRuntimeFromBonjourService before use — unchanged by this bump.
  • Follow-up: Consider a coordinated Dependabot PR for apps/ade-cli if you want the publish-side discovery improvements on the sync host path.
Open in Web View Automation 

Sent by Cursor Automation: BUGBOT in Versic

@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/apps/desktop/bonjour-service-1.4.0 branch 5 times, most recently from 769f516 to 840e7b8 Compare May 28, 2026 19:59
Bumps [bonjour-service](https://github.com/onlxltd/bonjour-service) from 1.3.0 to 1.4.0.
- [Release notes](https://github.com/onlxltd/bonjour-service/releases)
- [Commits](onlxltd/bonjour-service@1.3.0...1.4.0)

---
updated-dependencies:
- dependency-name: bonjour-service
  dependency-version: 1.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/apps/desktop/bonjour-service-1.4.0 branch from 840e7b8 to 1cb1664 Compare May 31, 2026 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants