Bump bonjour-service from 1.3.0 to 1.4.0 in /apps/desktop#343
Bump bonjour-service from 1.3.0 to 1.4.0 in /apps/desktop#343dependabot[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
PR author is in the excluded authors list. |
|
Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
There was a problem hiding this comment.
PR Review
Scope: 2 file(s), +5 / −5
Verdict: Needs changes
Dependabot bumps bonjour-service from 1.3.0 to 1.4.0 in apps/desktop only (lockfile + package.json). No application source changes. The blocker is that 1.4.0 changes the package's TypeScript export shape, which breaks the existing named type imports in LAN runtime discovery code and will fail the typecheck-desktop CI job.
🐛 Functionality
[High] bonjour-service@1.4.0 breaks desktop typecheck
File: apps/desktop/src/main/services/remoteRuntime/runtimeDiscovery.ts:L6-L7,L267,L269
Issue: Version 1.4.0 ships export = Bonjour with Service and Browser exposed as namespace values, not type-only exports. The existing import { …, type Browser, type Service as BonjourService } from "bonjour-service" then fails tsc with TS2749 ("refers to a value, but is being used as a type") on the BonjourServiceLike, Browser, and event-handler parameter types.
Repro: On the PR branch, run cd apps/desktop && npm ci && npm run typecheck — three errors in runtimeDiscovery.ts (verified locally against 1.4.0; clean with 1.3.0).
Fix: Either adjust imports to match 1.4.0's typings (e.g. import Bonjour, { Service, Browser } from "bonjour-service" and use import type / InstanceType<typeof Service> as needed), or pin at 1.3.0 until call sites are updated. apps/desktop/package.json:L84 is the version line that triggers the break.
Notes
- Positive: 1.4.0 adds browser
srv-update, TTL/lastSeentracking, and a publish-side fix for_services._dns-sd._udpbrowsing (#67). Desktop only browses_ade-sync._tcpindiscoverLanRuntimes, so the publish fix mainly matters ifapps/ade-cliis bumped too (it still pins^1.3.0). - Security / dependency: Same MIT package and maintainer; no new trust boundary in this diff. mDNS TXT is already normalized in
discoveredRuntimeFromBonjourServicebefore use — unchanged by this bump. - Follow-up: Consider a coordinated Dependabot PR for
apps/ade-cliif you want the publish-side discovery improvements on the sync host path.
Sent by Cursor Automation: BUGBOT in Versic
769f516 to
840e7b8
Compare
Bumps [bonjour-service](https://github.com/onlxltd/bonjour-service) from 1.3.0 to 1.4.0. - [Release notes](https://github.com/onlxltd/bonjour-service/releases) - [Commits](onlxltd/bonjour-service@1.3.0...1.4.0) --- updated-dependencies: - dependency-name: bonjour-service dependency-version: 1.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
840e7b8 to
1cb1664
Compare


Bumps bonjour-service from 1.3.0 to 1.4.0.
Release notes
Sourced from bonjour-service's releases.
Commits
92b7148Update README.mdb011099Delete install-state.gz3525cb6Update .gitignore332e76eUpdate publish-release.yml52c88c2Update publish-release.ymlfb7e6ecUpdate build-and-test.ymlabfdf05Update build-and-test.ymlb08aa2fUpdate build-and-test.yml5f1e277Update build-and-test.yml531026fUpdate build-and-test.yml