Bump @typescript-eslint/eslint-plugin from 6.21.0 to 8.60.0 in /apps/desktop#345
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
PR author is in the excluded authors list. |
|
Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
There was a problem hiding this comment.
PR Review
Scope: 2 file(s), +442 / −61
Verdict: Needs changes
Dependabot bumps @typescript-eslint/eslint-plugin to v8 in apps/desktop while @typescript-eslint/parser stays on v6. That skew breaks the desktop lint script, which CI runs on every PR.
🐛 Functionality
[High] Desktop lint crashes on plugin/parser version skew
File: apps/desktop/package.json:L134-L135
Issue: @typescript-eslint/eslint-plugin@8.59.4 declares a peer dependency on @typescript-eslint/parser@^8.59.4, but package.json still pins the parser at ^6.21.0. After install, npm ls reports the parser as invalid, and npm run lint exits with TypeError: Cannot use 'in' operator to search for 'type' in undefined while running @typescript-eslint/no-unused-vars (first failure at src/shared/types/models.ts:5).
Repro: In apps/desktop, run npm install then npm run lint.
Fix: Bump @typescript-eslint/parser to ^8.59.4 in the same change (regenerate package-lock.json) so plugin and parser share the v8 line. Re-run npm run lint and address any newly surfaced rule violations.
Notes
@typescript-eslint/eslint-pluginis a devDependency only; it does not ship in the Electron bundle or change runtime behavior..github/workflows/ci.ymlrunscd apps/desktop && npm run lint, so this mismatch will fail CI until the parser is aligned.- typescript-eslint v8 is actively maintained; the main risk here is the incomplete major bump, not the package choice itself.
Sent by Cursor Automation: BUGBOT in Versic
99554f9 to
d31ce37
Compare
96d53bc to
3764dc5
Compare
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.21.0 to 8.60.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.60.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-version: 8.59.4 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
3764dc5 to
710ad5b
Compare
|
Superseded by #425. |


Bumps @typescript-eslint/eslint-plugin from 6.21.0 to 8.60.0.
Release notes
Sourced from @typescript-eslint/eslint-plugin's releases.
... (truncated)
Changelog
Sourced from @typescript-eslint/eslint-plugin's changelog.
... (truncated)
Commits
f891c29chore(release): publish 8.60.0ca6ca14chore(release): publish 8.59.44302433fix(eslint-plugin): [no-floating-promises] stack overflow when using recursiv...10b79f1chore(deps): update dependency eslint to v10.4.0 (#12339)2a6765dchore: clenaupgetAwaitedTypefromtypescript.d.ts(#12302)48e13c0chore(release): publish 8.59.3e26dc80docs: update stale links to latest (#12313)44f9625chore(deps): update vitest monorepo to v4.1.5 (#12307)2ec35f1chore(release): publish 8.59.2ec3ef25test: make no-useless-empty-export tests fully static (#12260)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for
@typescript-eslint/eslint-pluginsince your current version.