Repository navigation
fix: re-encode multipart body on request retry - #819
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When a multipart request gets a retryable status (408, 429 or 5xx),
Internal::Http::RawClient#sendcallsrequest.encode_bodyagain for the retry.Internal::Multipart::FormDatakeeps oneEncoder, andEncoder#encodecloses it after the first call, so the retry raisesRuntimeError: Cannot write to closed encoderand is never sent. This affectsjobs.users_imports.create.This change makes
Encoder#encodestart from an empty body on each call. The boundary stays the same, so theContent-Typeheader built from it still matches the body on every attempt.Auth0::Internal::Multipart::Encoder#encode(internal,@api private). No public API changes.Auth0::Errors::ClientError, the same as JSON requests, instead of aRuntimeError.References
Testing
test/unit/internal/multipart/test_multipart_encoder.rbadds two tests:FormDatatwice returns the same payload, with one closing boundary.Multipart::Requestsent throughRawClientthat gets a 503 and then a 201 sends the same body on both attempts.Both tests fail on
masterwithRuntimeError: Cannot write to closed encoderand pass with this change.bundle exec rake testpasses on Ruby 3.3 (609 runs, 0 failures). The reproduction script from #818 now raisesAuth0::Errors::ClientErrorinstead ofRuntimeError.Checklist