Repository navigation
Pin Unix provisioning fixtures on Windows - #4387
Merged
Merged
Conversation
deehw
marked this pull request as ready for review
November 16, 2026 13:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows release validation treated Unix provisioning fixtures as Windows because only
isMacOSandisLinuxwere injected;isWindowsstill came from the test host. Pin all three flags in those fixtures so the existing Node 22 readiness/upgrade case tests its intended platform on x64 and ARM64. Product code, compatibility behavior and the Windows known-failure baseline are unchanged.Validation: reproduced the exact new failure from Windows run 43867714398 using its effective platform flags, then passed 54 tests across both provisioner files on macOS (six native Windows cases explicitly skipped). Changed-file Dart analysis passed. The local check mapper selects no additional gate. Native Windows validation runs once against corrected source
816d248dac6278f4965edabcd0a19b7f5f275047: x64 and ARM64 run. The earlier failing workflow is retained. Final headc26fd469e4a45398e83acec298867bb0f0f535c0integrates main8eaa76143f; Desktop, Windows rules, workflows and scripts are byte-identical to the native run source. The only incoming changes are the independently reviewed input fix; no additional local gate is selected.Design: test fixtures and the Windows testing rule only; no stored data, migration, hot-path change or UI change. Platforms affected: test execution on macOS, Linux, Windows x64 and Windows ARM64.
Final native result: Windows x64 and ARM64 both passed run43879376071, including the whole suite against the unchanged known-failure baseline, trusted pipe, runner/single-instance integration and installation. Final CI43886333683 passed; PR merged through the reviewed-head helper.