Skip to content

Pin Unix provisioning fixtures on Windows - #4387

Merged
deehw merged 3 commits into
mainfrom
codex/windows-node22-release-fix
Nov 16, 2026
Merged

deehw merged 3 commits into
mainfrom
codex/windows-node22-release-fix

Conversation

@deehw

@deehw deehw commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Windows release validation treated Unix provisioning fixtures as Windows because only isMacOS and isLinux were injected; isWindows still came from the test host. Pin all three flags in those fixtures so the existing Node 22 readiness/upgrade case tests its intended platform on x64 and ARM64. Product code, compatibility behavior and the Windows known-failure baseline are unchanged.

Validation: reproduced the exact new failure from Windows run 43867714398 using its effective platform flags, then passed 54 tests across both provisioner files on macOS (six native Windows cases explicitly skipped). Changed-file Dart analysis passed. The local check mapper selects no additional gate. Native Windows validation runs once against corrected source 816d248dac6278f4965edabcd0a19b7f5f275047: x64 and ARM64 run. The earlier failing workflow is retained. Final head c26fd469e4a45398e83acec298867bb0f0f535c0 integrates main 8eaa76143f; Desktop, Windows rules, workflows and scripts are byte-identical to the native run source. The only incoming changes are the independently reviewed input fix; no additional local gate is selected.

Design: test fixtures and the Windows testing rule only; no stored data, migration, hot-path change or UI change. Platforms affected: test execution on macOS, Linux, Windows x64 and Windows ARM64.

Final native result: Windows x64 and ARM64 both passed run43879376071, including the whole suite against the unchanged known-failure baseline, trusted pipe, runner/single-instance integration and installation. Final CI43886333683 passed; PR merged through the reviewed-head helper.

@deehw
deehw marked this pull request as ready for review November 16, 2026 13:50
@deehw
deehw merged commit 8ee115a into main Nov 16, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant