Markdown editor for item notes#187
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…Item Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… markdown Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/note/:itemId— one big textarea with an Edit/Preview toggle (react-markdown+remark-gfm), debounced autosave, and a save-status indicator.items.descriptionfield (no schema change). New Convex querygetItemForEditorloads the item with permission gating;updateItemnow caps descriptions at 50k.MAX_NOTE_LENGTH,clampNote,shouldPersist) insrc/lib/noteEditor.tswith unit tests.Design notes
draft: string | null), so a saved note resumes tracking the server value rather than holding stale text.rehype-raw/dangerouslySetInnerHTML— pasted HTML/<script>is inert./note/:itemIdgets "note not available" rather than an unreachable read-only branch.Test Plan
bun test scripts/— 68 pass (incl. newnote-editortests)npx tsc -bclean;npx eslintclean on new files;vite buildsucceeds<script>alert(1)</script>, Preview renders it inert/note/<bad-id>→ "This note isn't available."🤖 Generated with Claude Code