Repository navigation
feat(telemetry): add telemetry-4 full-tree map record - #185
Merged
Merged
Conversation
This was referenced Nov 10, 2026
Merged
This comment has been minimized.
This comment has been minimized.
Requirement telemetry-4 checks operation detail full-tree. The handler maps over [1, 2] with max concurrency 1. Each iteration runs one step. Under top-level detail the record would hold only the map. Under full-tree detail the record holds the map, both MapIteration contexts, and both steps. So the expected record pins five operationsByName keys: process-items, item-1, item-2, greet-1, greet-2. The history mirrors map/9-1 and map/9-13. Each iteration context carries the map's EventId as ParentId. Each step carries its iteration's EventId as ParentId. Context operations carry no maxAttempt. Every SDK reads maxAttempt from step details only. So the three CONTEXT summaries omit maxAttempt and the two STEP summaries require it. Refs #184
hln33
force-pushed
the
feat/telemetry-4-full-tree-map
branch
from
November 10, 2026 20:46
c7abf1b to
5c75e3f
Compare
Contributor
Codex AI reviewNo actionable findings. Residual test risk: this read-only review did not execute tests or independently verify SDK cloud conformance runs. Reviewed commit |
ParidelPooya
approved these changes
Nov 10, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds requirement
telemetry-4to the telemetry suite. The handler runs onemapnamedprocess-itemsover[1, 2]with max concurrency 1. The item namer names each iterationitem-<item>. Each iteration runs one stepgreet-<item>that returns"Hello, <item>!". The plugin runs with operation detailfull-treeand contentinputandoutputon. The exported record must carry exactly fiveoperationsByNamekeys:process-items(CONTEXT/Map),item-1anditem-2(CONTEXT/MapIteration),greet-1andgreet-2(STEP/Step).Refs #184. This PR covers the conformance-repo half of that issue. The SDK handlers and SAM mappings land in each SDK repository.
Why
Under
top-leveldetail the record holds onlyprocess-items. The validator closes every mapping (validators.py:132–141), so a record that drops the iteration contexts or the depth-2 steps fails withoperationsByName: expected mapping with keys [...], got <missing>. A plugin that merges the two steps into onegreetkey fails on both the missing names and an unexpected key. So this requirement detects a plugin that stops recursion at depth 1 or keys children by a name other than the user-supplied one.Context operations carry no
maxAttempt. Every SDK readsmaxAttemptfrom step details only (JSoperation.ts:45, Python coreplugin.py:130–131, JavaPluginInfoConverter.java:202). So the three CONTEXT summaries omitmaxAttemptand the two STEP summaries require it with value 1.Changes
test-requirements/telemetry/telemetry-4.yaml: the requirement. History mirrorsmap/9-1andmap/9-13: each iteration context carries the map's EventId asParentId, each step carries its iteration's EventId asParentId.tests/test_telemetry_validators.py: a telemetry-4 fixture record and the error each defect produces (top-level-only record, dropped iteration contexts, dropped depth-2 steps, mergedgreetkey with count 2, step payloads present, iteration keyed by id,maxAttempton a context, each field missing).tests/test_telemetry_resources.py: telemetry-4 in the requirement set, event sequence andParentIdchain, the five operation names.scripts/smoke_wheels.py: telemetry range1..4.README.md: list telemetry-4.No validator code change.
SDK coverage
full-treeoperation detailmainoperationDetail: "full-tree"operation_detail="full-tree"OperationDetail.FULL_TREENOT_IMPLEMENTEDVerification
hatch run test:telemetry: 1521 passed.hatch run types:check: no issues in 74 files.hatch fmt --check packages scripts: all checks passed.hatch run yaml:lint: clean.Cloud conformance runs. Each SDK handler PR pinned
telemetry-suite.ymltoc7abf1band ran telemetry-4 in CI. This branch was later rebased onto main after #183 merged (telemetry-3 was stacked underneath). The rebased head5c75e3fhas an identical tree toc7abf1b. The SDK PRs are re-pinned to5c75e3f(JS8ad5f40e, Python076a6321, Javafcc7a5f89). Runs below are againstc7abf1b:e5bb828960cfa998cf7dfab51