Skip to content

feat(telemetry): add telemetry-4 full-tree map record - #185

Merged
hln33 merged 1 commit into
mainfrom
feat/telemetry-4-full-tree-map
Nov 10, 2026
Merged

hln33 merged 1 commit into
mainfrom
feat/telemetry-4-full-tree-map

Conversation

@hln33

@hln33 hln33 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

What

Adds requirement telemetry-4 to the telemetry suite. The handler runs one map named process-items over [1, 2] with max concurrency 1. The item namer names each iteration item-<item>. Each iteration runs one step greet-<item> that returns "Hello, <item>!". The plugin runs with operation detail full-tree and content input and output on. The exported record must carry exactly five operationsByName keys: process-items (CONTEXT/Map), item-1 and item-2 (CONTEXT/MapIteration), greet-1 and greet-2 (STEP/Step).

Refs #184. This PR covers the conformance-repo half of that issue. The SDK handlers and SAM mappings land in each SDK repository.

Why

Under top-level detail the record holds only process-items. The validator closes every mapping (validators.py:132–141), so a record that drops the iteration contexts or the depth-2 steps fails with operationsByName: expected mapping with keys [...], got <missing>. A plugin that merges the two steps into one greet key fails on both the missing names and an unexpected key. So this requirement detects a plugin that stops recursion at depth 1 or keys children by a name other than the user-supplied one.

Context operations carry no maxAttempt. Every SDK reads maxAttempt from step details only (JS operation.ts:45, Python core plugin.py:130–131, Java PluginInfoConverter.java:202). So the three CONTEXT summaries omit maxAttempt and the two STEP summaries require it with value 1.

Changes

  • test-requirements/telemetry/telemetry-4.yaml: the requirement. History mirrors map/9-1 and map/9-13: each iteration context carries the map's EventId as ParentId, each step carries its iteration's EventId as ParentId.
  • tests/test_telemetry_validators.py: a telemetry-4 fixture record and the error each defect produces (top-level-only record, dropped iteration contexts, dropped depth-2 steps, merged greet key with count 2, step payloads present, iteration keyed by id, maxAttempt on a context, each field missing).
  • tests/test_telemetry_resources.py: telemetry-4 in the requirement set, event sequence and ParentId chain, the five operation names.
  • scripts/smoke_wheels.py: telemetry range 1..4.
  • README.md: list telemetry-4.

No validator code change.

SDK coverage

SDK full-tree operation detail Telemetry conformance module on main Expected status
JS operationDetail: "full-tree" yes pass
Python operation_detail="full-tree" yes pass
Java OperationDetail.FULL_TREE yes pass
Go no telemetry plugin no NOT_IMPLEMENTED

Verification

  • hatch run test:telemetry: 1521 passed.
  • hatch run types:check: no issues in 74 files.
  • hatch fmt --check packages scripts: all checks passed.
  • hatch run yaml:lint: clean.

Cloud conformance runs. Each SDK handler PR pinned telemetry-suite.yml to c7abf1b and ran telemetry-4 in CI. This branch was later rebased onto main after #183 merged (telemetry-3 was stacked underneath). The rebased head 5c75e3f has an identical tree to c7abf1b. The SDK PRs are re-pinned to 5c75e3f (JS 8ad5f40e, Python 076a6321, Java fcc7a5f89). Runs below are against c7abf1b:

SDK PR Head Telemetry Conformance Tests run Result
JS aws/aws-durable-execution-sdk-js#1212 e5bb8289 42759197044 success
Python aws/aws-durable-execution-sdk-python#924 60cfa998 42759200974 success
Java aws/aws-durable-execution-sdk-java#888 cf7dfab51 42759206222 success

@github-actions

This comment has been minimized.

Requirement telemetry-4 checks operation detail full-tree. The handler maps
over [1, 2] with max concurrency 1. Each iteration runs one step. Under
top-level detail the record would hold only the map. Under full-tree detail
the record holds the map, both MapIteration contexts, and both steps. So the
expected record pins five operationsByName keys: process-items, item-1,
item-2, greet-1, greet-2.

The history mirrors map/9-1 and map/9-13. Each iteration context carries the
map's EventId as ParentId. Each step carries its iteration's EventId as
ParentId.

Context operations carry no maxAttempt. Every SDK reads maxAttempt from step
details only. So the three CONTEXT summaries omit maxAttempt and the two STEP
summaries require it.

Refs #184
@hln33
hln33 force-pushed the feat/telemetry-4-full-tree-map branch from c7abf1b to 5c75e3f Compare November 10, 2026 20:46
@hln33
hln33 deployed to ai-pr-review-runtime November 10, 2026 20:47 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

Codex AI review

No actionable findings. Residual test risk: this read-only review did not execute tests or independently verify SDK cloud conformance runs.

Reviewed commit 5c75e3f2d8e31d959114547bedad9c18afa0884b. Workflow run

@hln33
hln33 merged commit b380cbf into main Nov 10, 2026
15 checks passed
@hln33
hln33 deleted the feat/telemetry-4-full-tree-map branch November 10, 2026 22:06

This branch was successfully deployed

1 active deployment
ai-pr-review-runtime — 5c75e3f2 Deployed Nov 10, 2026 by hln33 via ai-pr-review / Codex review / Generate Codex review #935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants