Skip to content

fix(lmi): flag late peer dispatch without closure evidence - #198

Open
zhongkechen wants to merge 4 commits into
codex/lmi-warm-reuse-event-orderfrom
codex/lmi-peer-dispatch-repro
Open

zhongkechen wants to merge 4 commits into
codex/lmi-warm-reuse-event-orderfrom
codex/lmi-peer-dispatch-repro

Conversation

@zhongkechen

@zhongkechen zhongkechen commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

The peer in the lmi-lifecycle-1 fixture ends at 42 ms but records an SDK dispatch at 100 ms. When its wrapper return is missing, both validators previously accepted the evidence.

The validators now report incomplete evidence for a dispatch strictly after the attempt's recorded end when no admission closure was recorded. The recorded end alone cannot establish when admission closed. An observed dispatch at or after an explicit closure remains an assertion failure.

Regression tests cover both validators and phases, including dispatch before and at the recorded end, rejected requests, and the existing explicit closure assertion. The original report is in the #193 review.

@zhongkechen
zhongkechen changed the base branch from feat/lmi-4-workflow to codex/lmi-warm-reuse-event-order November 18, 2026 18:58
@zhongkechen
zhongkechen added this pull request to stack #196 November 18, 2026 18:58
@zhongkechen
zhongkechen force-pushed the codex/lmi-peer-dispatch-repro branch from 9c3d17c to e18b1bb Compare November 19, 2026 22:36
@zhongkechen zhongkechen changed the title test(lmi): reproduce peer dispatch without a recorded wrapper return fix(lmi): flag late peer dispatch without closure evidence Nov 19, 2026
@zhongkechen
zhongkechen marked this pull request as ready for review November 19, 2026 23:06
@zhongkechen
zhongkechen deployed to ai-pr-review-runtime November 19, 2026 23:06 — with GitHub Actions Active
@zhongkechen
zhongkechen deployed to ai-pr-review-runtime November 19, 2026 23:07 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime November 19, 2026 23:18 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

Codex AI review

No actionable findings in the PR changes. Regression tests cover both validators, validation phases, and dispatch boundaries. Residual risk: tests and type checks were inspected but not executed, as required.

Reviewed commit b754233a9cb0cb10f671365aecb6bfdbbdea5336. Workflow run

This branch was successfully deployed

1 active deployment
ai-pr-review-runtime — b754233a Deployed Nov 19, 2026 by zhongkechen via ai-pr-review / Codex review / Generate Codex review #1253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant