Repository navigation
fix(lmi): flag late peer dispatch without closure evidence - #198
Open
zhongkechen wants to merge 4 commits into
Open
zhongkechen wants to merge 4 commits into
zhongkechen wants to merge 4 commits into
Conversation
zhongkechen
changed the base branch from
feat/lmi-4-workflow
to
codex/lmi-warm-reuse-event-order
November 18, 2026 18:58
zhongkechen
force-pushed
the
codex/lmi-peer-dispatch-repro
branch
from
November 19, 2026 22:36
9c3d17c to
e18b1bb
Compare
zhongkechen
marked this pull request as ready for review
November 19, 2026 23:06
This comment has been minimized.
This comment has been minimized.
Contributor
Codex AI reviewNo actionable findings in the PR changes. Regression tests cover both validators, validation phases, and dispatch boundaries. Residual risk: tests and type checks were inspected but not executed, as required. Reviewed commit |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The peer in the
lmi-lifecycle-1fixture ends at 42 ms but records an SDK dispatch at 100 ms. When its wrapper return is missing, both validators previously accepted the evidence.The validators now report incomplete evidence for a dispatch strictly after the attempt's recorded end when no admission closure was recorded. The recorded end alone cannot establish when admission closed. An observed dispatch at or after an explicit closure remains an assertion failure.
Regression tests cover both validators and phases, including dispatch before and at the recorded end, rejected requests, and the existing explicit closure assertion. The original report is in the #193 review.