Repository navigation
Conversation
Adds a step that mirrors the Docker usage of llrt-cloud-test.js (busybox-based linux/amd64 build, then run) on both the CodeBuild project default and ubuntu-latest. The real LLRT workflow cannot be dispatched from this branch because the test role's OIDC trust only covers pull_request, main and tag subjects.
Runs prepare_ai_review_user.sh (claude-review, codex-review), prepare_ai_summary_user.sh and prepare_codex_implementation_user.sh from aws-durable-execution-ci@d901b2f as the real job account on the CodeBuild project default (root) and on ubuntu-latest (runner), then mirrors each workflow's env -i launch with a stub binary to show exactly which variables reach the model process.
|
|
||
| on: | ||
| workflow_dispatch: | ||
| pull_request: |
There was a problem hiding this comment.
Codex AI review · Finding arf_v1_rsxkeo6em43qllvaijkvz3rnp6
[P1] Keep PR-authored code off the CodeBuild runner
A pull_request workflow runs the PR's workflow definition, allowing a contributor to replace these probe commands and execute arbitrary code on the CodeBuild runner. Restricting GITHUB_TOKEN permissions does not protect the runner's ambient AWS service-role credentials. The same exposure exists in ci-toolkit-scripts-probe.yml. Remove both pull_request triggers and use only a trusted push/manual invocation, or a base-branch pull_request_target workflow that never executes the head revision.
Codex AI reviewFound one high-severity CI trust-boundary issue in the new CodeBuild probes. No SDK runtime behavior is changed. Reviewed commit |
Purpose
Temporary probe, not for merge. Records which account the CodeBuild-hosted runner executes as and whether the assumptions baked into the shared AI review workflows in
aws-durable-execution-cihold there:runner(Defaults:runner env_keep,chown runner:<user>,install -o runner)/home/runnerexists and is the parent ofGITHUB_WORKSPACEThe same script runs on the CodeBuild project default (EC2,
standard:7.0) and onubuntu-latestas a control.What it checks
id,$HOME, presence of arunneraccount/group and/home/runnerGITHUB_WORKSPACElocation and its parent chain (namei -l)visudo,setfaclavailabilityAWS_CONTAINER_*/CODEBUILD_*variable names (values never printed), reachability of169.254.170.2and IMDSDefaults:runner env_keepsudoers rule matches the actual invoker, versusDefaults:$(id -un)probe-user: inherited AWS variables, credential endpoint reachability, ability to read root/sudo process environ, workspace traversabilitychown runner:…/install -o runnersucceed against the literalrunneraccountContext: Codex finding on aws/aws-durable-execution-ci#67.