Skip to content

ci: run shared workflows on the CodeBuild runner - #973

Merged
zhongkechen merged 8 commits into
mainfrom
ci/codebuild-runner-shared-shells
Oct 14, 2026
Merged

zhongkechen merged 8 commits into
mainfrom
ci/codebuild-runner-shared-shells

Conversation

@wangyb-A

@wangyb-A wangyb-A commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The AI PR review, issue triage, Slack notification, and stale-issue closer workflows still run on the shared ubuntu-latest pool. Pass the JavaScript testing account's CodeBuild runner label to these four reusable workflow callers, completing the shared CI portion of #937.

Pin all four callers to 8ea82196db65b5b0dd67f0b72bb03fa2fa9cf65b, which is four commits after 288e4317948ca778ebf01acca9342d8b898a1dc2 (the merged commit from aws/aws-durable-execution-ci#67 that introduced the runs-on input). The pinned revision retains that input in all four reusable workflows and both nested AI review workflows, and includes subsequent dependency, model-default, and Claude turn-limit fixes.

Merged main into the branch, preserving its updated stale-issue schedule and OTel workflow. OTel's CodeBuild migration, newer conformance orchestrator pin, and tested Node 22 setup helper are already on main; the resulting PR diff contains only the four CI workflow callers.

Validation

  • Parsed the four callers at 6f6b7b86 and all six referenced shared workflows at 8ea82196 with duplicate-key detection; verified supplied/required inputs, explicit secrets, and CodeBuild runner propagation through both nested AI review workflows.
  • actionlint 1.7.12 passed for all four modified callers.
  • Parsed all 16 workflow YAML files and checked for duplicate keys.
  • Validated supplied inputs, required inputs, explicit secrets, and permissions against the exact pinned reusable workflow contracts, including nested AI review and OTel workflows.
  • Node 22 setup tests: all three offline fixtures passed. Shell syntax and git diff --check passed.
  • Previous CodeBuild runtime verification: reusable review run and model-user scripts running as root. These four callers use main's workflow definitions, so their first event after merge exercises the updated callers.

No linked issue: follow-up to #937.

Alex Wang and others added 6 commits October 6, 2026 23:43
Bump the aws-durable-execution-ci and conformance-tests orchestrator pins to the commits that accept a runner input, and pass the CodeBuild runner label from every thin shell.
The CodeBuild standard image has no nvm; it ships n with Node 22 preinstalled. Fall back to n when nvm is absent and fail if neither yields Node 22.
@hln33
hln33 marked this pull request as ready for review October 14, 2026 01:32
@hln33
hln33 temporarily deployed to ai-pr-review-runtime October 14, 2026 01:32 — with GitHub Actions Inactive
@hln33
hln33 had a problem deploying to ai-pr-review-runtime October 14, 2026 01:42 — with GitHub Actions Error
@hln33
hln33 temporarily deployed to ai-pr-review-runtime October 14, 2026 01:48 — with GitHub Actions Inactive
Comment thread .github/workflows/ai-pr-review.yml Resolved
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime October 14, 2026 20:02 — with GitHub Actions Inactive
Comment thread .github/workflows/ai-pr-review.yml Resolved
@github-actions

Copy link
Copy Markdown

Codex AI review

One high-priority CI correctness issue was found; no additional findings in the runner-label changes.

Reviewed commit 6f6b7b86fdea656659d49d0c50caece775790b93. Workflow run

@zhongkechen
zhongkechen merged commit 4ed4502 into main Oct 14, 2026
20 checks passed
@zhongkechen
zhongkechen deleted the ci/codebuild-runner-shared-shells branch October 14, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants