Skip to content

[AgentCore session] Remove the unused session timeout #970

Open

Description

@ParidelPooya

Part of the agentcore_session epic, #954.

What

Remove timeout from AgentcoreSessionConfig.

Why

  1. AgentcoreSessionConfig.timeout says it is the lifetime of the session.
  2. agentcore_session only checks that the value is at least 1 second. Nothing ends the session when the time is up. A handler can wait longer, and the session stops only when the handler returns.
  3. The agent runtime's maxLifetime already ends every session. Each job also has its own timeout and heartbeat_timeout in AgentcoreInvokeOptions.
  4. So the session timeout adds a setting that does nothing. Enforcing it would need a durable deadline that stops the session, which is more code for a limit the runtime already sets.

So the session config drops the field, and the docs state the rule instead: the runtime's maxLifetime ends the session, and a job that still runs then ends with it.

Done when

  • AgentcoreSessionConfig has no timeout. The config check no longer checks it for a session.
  • The type docs and the epic rule 2 say that maxLifetime ends the session.
  • AgentcoreInvokeOptions.timeout and heartbeat_timeout do not change.

Context

Found in review of #968.

Keep the pull request to this item only. The twin item is in aws/aws-durable-execution-sdk-js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions