Skip to content

fix: use the core MAP_TRIAL_OF_THE_CRUSADER instead of redefining it - #1

Merged
Nyeriah merged 1 commit into
masterfrom
fix/map-constant-clash
Oct 31, 2026
Merged

Nyeriah merged 1 commit into
masterfrom
fix/map-constant-clash

Conversation

@Nyeriah

@Nyeriah Nyeriah commented Oct 31, 2026

Copy link
Copy Markdown
Member

The module doesn't compile against current AzerothCore. The MAP_TRIAL_OF_THE_CRUSADER constant in the anonymous namespace clashes with the Maps enum value of the same name in src/server/game/Maps/AreaDefines.h, so every use is ambiguous:

mod_crossfaction_toc.cpp:181:87: fatal error: reference to 'MAP_TRIAL_OF_THE_CRUSADER' is ambiguous
AreaDefines.h:271:5: note: candidate found by name lookup is 'MAP_TRIAL_OF_THE_CRUSADER'
mod_crossfaction_toc.cpp:22:22: note: candidate found by name lookup is '(anonymous namespace)::MAP_TRIAL_OF_THE_CRUSADER'

This drops the local constant and includes AreaDefines.h directly, so the core value (649) is used.

The local constant in the anonymous namespace clashes with the Maps enum
in AreaDefines.h, making every use ambiguous and failing the build.
@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ea56b130-b3a2-4483-a56f-66ab9965d868
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Nyeriah
Nyeriah merged commit 747f47a into master Oct 31, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant