Reenable beep on touch for buttons (but not empty space)#44
Open
Funkenjaeger wants to merge 1 commit into
Open
Reenable beep on touch for buttons (but not empty space)#44Funkenjaeger wants to merge 1 commit into
Funkenjaeger wants to merge 1 commit into
Conversation
Author
|
Note that this requires some system changes outside of the RCP repo to get sound working (at least with my raspberry pi 5 and the wisecoco touchscreen display you sell). Namely, create You might instead be able to edit /etc/asound.conf and change the default cards from 1 to 0 there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reenables the beep functionality. It uses pygame, as with Kivy's SoundLoader I could not seem to eliminate a noticeable lag between button press and the sound playing.
This also switches away from using "on_touch_down" on the HomePage as a catch-all that caused it to beep when you touch anywhere at all, including empty spaces. Instead the beep function is associated with each button (etc.), so it only beeps when you tap something actually interactive.