feat: verbose kept only for json format

Author: Luca Bassani

messages/connected-objects.upsert.md

@@ -43,10 +43,6 @@ Print the changed fields into the outcome table
 
 Recipes not found in the repository
 
-# nothing.changed
-
-Nothing changed
-
 # connector.not.found
 
 Connector named %s not found. Create an empty data connection to proceed

src/commands/analytics/connected-objects/upsert.ts

@@ -4,7 +4,6 @@ import { Messages, SfError } from '@salesforce/core';
 import { MetadataHelper } from '../../../metadataHelper.js';
 import { ApiHelper } from '../../../apiHelper.js';
 import { RecipeDefinition, LoadDefinitionNodeParam, ReplicatedDataset } from '../../../modules/upsert.js';
-import { PrinterHelper } from '../../../printerHelper.js';
 
 Messages.importMessagesDirectoryFromMetaUrl(import.meta.url);
 const messages = Messages.loadMessages('plugin-analytics-connected-objects', 'connected-objects.upsert');
@@ -50,7 +49,7 @@ export default class ConnectedObjectsUpsert extends SfCommand<ConnectedObjectUps
     }),
     verbose: Flags.boolean({
       summary: messages.getMessage('flags.verbose.summary'),
-    }),
+    })
   };
 
   public async run(): Promise<ConnectedObjectUpsertResult[]> {
@@ -114,7 +113,6 @@ export default class ConnectedObjectsUpsert extends SfCommand<ConnectedObjectUps
         }
         const fieldSet = objectFields.get(dataset.sourceObjectName) as Set<string>;
         const { changedFields, missingFields } = await service.updateReplicatedDatasetFields(dataset.id, fieldSet);
-
         if (missingFields.length > 0) {
           const message = messages.getMessage('fields.not.found', [
             objectName,
@@ -123,11 +121,10 @@ export default class ConnectedObjectsUpsert extends SfCommand<ConnectedObjectUps
           ]);
           warnMessages.push(message);
         }
-        if (changedFields.length > 0) {
-          const item = resultMap.get(dataset.sourceObjectName) as ConnectedObjectUpsertResult;
-          item.fields = changedFields;
-          item.fieldsCount = changedFields.length;
-        }
+        const item = resultMap.get(dataset.sourceObjectName) as ConnectedObjectUpsertResult;
+        item.fields = changedFields;
+        item.fieldsCount = changedFields.length;
+        item.operation = changedFields.length === 0 ? 'Unchanged' : item.isNew ? 'Created' : 'Updated';
         current++;
         progressBar.update(current);
       }
@@ -142,15 +139,8 @@ export default class ConnectedObjectsUpsert extends SfCommand<ConnectedObjectUps
         this.warn(warnMessage);
       }
     }
-
-    const result: ConnectedObjectUpsertResult[] = Array.from(resultMap.values()).filter(
-      (x) => x.fields && x.fields.length > 0
-    );
-    if (result.length > 0) {
-      this.printConnectionUpgradeResult(result, flags.verbose);
-    } else {
-      this.log(messages.getMessage('nothing.changed'));
-    }
+    const result: ConnectedObjectUpsertResult[] = Array.from(resultMap.values());
+    this.printConnectionUpgradeResult(result);
     return result;
   }
 
@@ -184,23 +174,13 @@ export default class ConnectedObjectsUpsert extends SfCommand<ConnectedObjectUps
     return response;
   }
 
-  private printConnectionUpgradeResult(records: ConnectedObjectUpsertResult[], verbose: boolean): void {
+  private printConnectionUpgradeResult(records: ConnectedObjectUpsertResult[]): void {
     const columns = [
-      { key: 'objectName', name: 'OBJECT' },
-      { key: 'connectorName', name: 'CONNECTOR' },
-      { key: 'operation', name: 'OPERATION' },
-      { key: 'fieldsCount', name: 'FIELDSCOUNT' },
-      { key: 'fields', name: 'FIELDS' }
+      { key: 'objectName', name: 'Object' },
+      { key: 'connectorName', name: 'Connector' },
+      { key: 'operation', name: 'Operation' },
+      { key: 'fieldsCount', name: 'Added Fields' }
     ];
-    for(const record of records) {
-      record.operation = record.isNew ? 'Created' : 'Updated';
-    } 
-    if (verbose) {
-      columns.push({ key: 'connectorName', name: 'CONNECTOR' });
-      for(const record of records) {
-        record.fieldDetails = PrinterHelper.printFieldsMultiline(record.fields!, 60);
-      }
-    }
     this.table({
       data: records,
       columns

src/printerHelper.ts

@@ -124,7 +124,8 @@ describe('analytics recipe run', () => {
     );
     const cmd = new ConnectedObjectsUpsert([...commandParams, '--json', '--verbose'], config);
     const result = await cmd.run();
-    expect(result).to.lengthOf(0);
+    expect(result).to.lengthOf(1);
+    expect(result[0].fieldsCount).to.equal(0);
   });
 });