Repository navigation
Keep development-only packages out of the release archive - #1615
Open
Spikhalskiy wants to merge 1 commit into
Open
Spikhalskiy wants to merge 1 commit into
Spikhalskiy wants to merge 1 commit into
Conversation
Spikhalskiy
force-pushed
the
downstream-dev-dependencies
branch
from
November 11, 2026 05:25
458f12f to
a78ce0e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps gazelle, rules_shellcheck and rules_bazel_integration_test as dev dependencies and stops shipping the packages that load them:
gazelleandgazelle_binarytargets move from the root package to//tools/gazelle. Gazelle still runs over the whole repository (bazel run //tools/gazelle)..gitattributesmarkstest/andtools/gazelle/asexport-ignore, excepttest/integration/basic, the BCR presubmit module. Both the release archive fromrelease_prep.shand GitHub's source archives are built withgit archive, so neither contains those packages.With an archive built this way,
bazel query '@rules_foreign_cc//...'from a consumer module loads every package, and the consumer's module graph is unchanged. Promoting the dev dependencies instead would not cover the nested scenario workspaces undertest/integration/(e.g.rule_based_toolchainloads@msvc_tools). It would also add gazelle, rules_go and rules_shellcheck to every consumer's resolution.A new
downstream_queryintegration scenario (via a newEXPECT_QUERYrunner assertion) queries@rules_foreign_cc//...from a downstream module against the staged distribution, which covers the root package.Fixes #1614