feat(backups): record S3 traffic tallies on backup runs#282
Merged
Conversation
bestool's proxy now reports the S3 traffic it saw during a run: raw (full HTTP message incl. SigV4 chunk framing) vs payload (decoded object data), for both sent and received. Persist the four figures on backup_runs and the BackupReport ingest, on both success and failure. The recent-runs table surfaces them in each run's expandable detail row, and the Uploaded column falls back to the S3 payload-sent figure (marked approximate) when bestool reports no explicit upload size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 bestool's proxy now reports the S3 traffic it observed during a run:
raw(the full HTTP message, including SigV4 chunk framing) versuspayload(decoded object data), for both sent and received. This persists the four figures end-to-end.BIGINTcolumns onbackup_runs:s3_sent_raw_bytes,s3_sent_payload_bytes,s3_received_raw_bytes,s3_received_payload_bytes.POST /backup-report(ReportArgs) accepts the four fields and stores them, on both success and failure. Older clients that omit them keep working (fields are optional).bytes_uploaded, the Uploaded column falls back to the S3 payload-sent figure, marked approximate (~).Both openapi specs and
api-types.tsare regenerated. Playwright coverage added for the approximate-upload fallback and the S3 traffic detail row.