Repository navigation
fix(window): fit main window to half-screen tiling cells - #4254
ranrany123 wants to merge 1 commit into
Conversation
macOS and Windows window tiling keep the app's minimum size when the requested cell is smaller, so the 1100x640 minimum pushed half-tiled windows past the screen edge. Cap the effective minimum at half the display work area minus the macOS tiling margin, and pull restored bounds back inside the work area while preserving windows that span adjacent displays. Let Vault page headers wrap their action buttons on narrow half-screen windows instead of clipping them. Tests: window manager suite (127) and Vault header/layout tests pass. Co-Authored-By: Claude Code <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5da8466416
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Wrap instead of clipping when the window is tiled to a narrow | ||
| // half-screen cell: the search row keeps its controls and the | ||
| // fixed-width action buttons move to a second row. | ||
| "min-h-14 px-4 py-2 flex flex-wrap items-center gap-x-3 gap-y-2 app-no-drag", |
There was a problem hiding this comment.
Allow nested action groups to wrap at the new tiling widths
On a 1366px display at 125% scaling, the newly permitted half-screen window is about 546 logical pixels wide; the default 208px Vault sidebar leaves less than 300px for the header's contents. In the first-party Keychain view, KeychainManager.tsx:595-651 puts New Key, Import Certificate, and New Identity inside one non-wrapping flex child with non-shrinking buttons. Wrapping this outer container cannot split that action group, so it remains wider than the available space and the Keychain root's overflow-hidden clips the rightmost actions instead of moving them onto another row. Make the nested action groups wrap or collapse as well so those controls remain visible at the newly supported window sizes.
Useful? React with 👍 / 👎.
Summary
Fixes the main window spilling past the screen edge when macOS or Windows tiles it to a half-screen (or quarter-screen) cell. Window tiling keeps the app's minimum size, so the previous 1100×640 minimum produced a 1100px-wide window inside a ~735px cell and pushed the window partly off screen. Restored window bounds could also reopen partially off screen.
Type of Change
Related Issue (optional)
N/A
Changes Made
VaultPageHeaderwrap its action buttons on narrow half-screen widths instead of clipping them.Screenshots / Demo
Verified in the built app on a 1470×956 logical Mac display (macOS 27.2):
{x:499,y:253,width:1100,height:838}reopens at{x:370,y:43}.Testing
npm run lint)npm test) — targeted window-manager (127) and Vault header/layout suites pass locally; the full local run on Node 26 has 8 environment/build-artifact failures unrelated to this change (plugin example fixtures, PTY/path tests). CI runs the full suite on Node 22 after the example-plugin build steps.npm run generate:capability-tools) — not applicable; no capability catalog changesChecklist
Documentation: not applicable — this changes internal window sizing and narrow-window layout only.
🤖 Generated with Claude Code