Repository navigation
fix: reject non-string mnemonic seed inputs - #205
Open
Harshil-1603 wants to merge 1 commit into
Open
Harshil-1603 wants to merge 1 commit into
Harshil-1603 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Falsy non-string mnemonic inputs (
undefined,null,false,0, andNaN) currently normalize to an empty string and derive the same seed. Check the mnemonic's runtime type in both seed entry points and throwTypeError: Invalid mnemonicconsistently for non-string inputs.Addresses the non-string input case in #77. Empty strings, whitespace, and other non-strict string mnemonics retain their existing derivation behavior, following the discussion that mnemonic validity belongs to the caller. Passphrase behavior is unchanged.
Add 20 invalid-type assertions and 8 compatibility assertions against Node's independent PBKDF2 implementation. Include the regenerated JavaScript.
Validation:
npm test: 411 assertions passed, including official BIP39 wordlist comparisons; build, formatting, and lint passed.npm run coverage: passed the 85% branch and 100% function thresholds.npm run gitdiff:ciandgit diff --checkpassed.