Repository navigation
berd-call: add persistent Auto input muting - #403
Draft
johnmatthewtennant wants to merge 2 commits into
Draft
johnmatthewtennant wants to merge 2 commits into
johnmatthewtennant wants to merge 2 commits into
Conversation
added 2 commits
October 20, 2026 15:01
Signed-off-by: Nora <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz>
Signed-off-by: Nora <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Berd Call chooses a speaker-dependent microphone policy at startup, but changing its mute checkbox permanently replaces that automatic choice. Add a saved Auto preference alongside On and Off, expose all three in the menu, and accept
berd-call settings --input-during-tts auto.Auto suppresses input during speech on built-in speakers and permits interruption on other default outputs. It follows output changes during a call. Explicit On/Off choices remain fixed. Conventional calls apply route changes through the existing mute epoch logic, and Spokesperson calls resolve Auto before forwarding microphone audio. Berd desktop shares the route-classification helper while retaining its existing selected-output behavior.
Related issue
N/A. Searches for
auto mutefound no matching issue or PR title. The companion Buzz plugin offers the same three choices and checks CLI support before saving Auto for a future call. Its Auto control requires a berd-call binary that acceptssettings --input-during-tts auto.Testing
Normal publication hooks passed: formatting, frontend checks, desktop Rust checks, and Clippy (Rust 1.94.1).
An isolated native call accepted suppress, auto, allow, auto and retained Auto through a session restart.
An opt-in macOS regression switched the real default output from built-in speakers to BlackHole 2ch and back during an assistant activity. Input suppression followed each change, and the original output was restored. Run with
cargo test -p berd-call native_auto_mute_follows_default_output_during_speech -- --ignoredon a Mac with SwitchAudioSource and BlackHole 2ch.Unit coverage checks route-dependent muting and epochs, manual microphone mute, explicit overrides, saved preference reopening, CLI parsing, and menu selection/actions.
Companion plugin: 61 tests, production build, and a headless Chromium journey through Buzz plugin installation and settings persistence passed. Native process IPC is the browser fixture boundary; the actual CLI is covered by the isolated call above.
Full package execution at
b2dcf8e7has the same four failing targets as the base. Their failures also reproduce with working sources verified equal to base629e0af8c1065cb67d2f7dcd04912eece6e8f6a6: the Spokesperson saved-voice test, management/synthesis usage tests, and provider-expiry handoff test. The input-cutover timing test also failed intermittently on the feature tree.Native menu screenshot automation timed out. Menu state and actions have automated model coverage; native menu interaction and its screenshot remain unverified.
Screenshots
Companion Buzz plugin settings: