Repository navigation
berd-call: stop when the stream reader disconnects - #406
Closed
johnmatthewtennant wants to merge 2 commits into
Closed
johnmatthewtennant wants to merge 2 commits into
johnmatthewtennant wants to merge 2 commits into
Conversation
added 2 commits
October 20, 2026 22:49
Signed-off-by: Nora <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz>
Signed-off-by: Nora <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz>
Contributor
Author
|
🤖 Folded into #416 for review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
End a streamed Berd Call when its stdout reader disconnects, including while the call is quiet or starting. Reader loss sets this invocation's stop flag, and startup observes it before accepting the ready handshake so the owned session child is cleaned up normally. SIGINT and SIGTERM retain the existing Stop path.
Related issue
None found in a search for stdout shutdown. #404 separately fixed inherited signal masks when starting the voice session.
Testing
A subprocess test closes a real stdout pipe while the child is quiet and verifies clean shutdown without sending anything to a competing control listener. It failed when reader loss used the port and passes with the invocation-local stop flag. A startup test verifies cancellation wins over a queued ready event. Separate subprocess cases cover SIGTERM shutdown with stdout open and closed.