Repository navigation
berd-call: download Siri voices from the menu bar - #407
Closed
johnmatthewtennant wants to merge 1 commit into
Closed
johnmatthewtennant wants to merge 1 commit into
johnmatthewtennant wants to merge 1 commit into
Conversation
The menu bar's voice submenu listed only installed Siri voices, so a voice had to be downloaded with `berd-call voices download` before it could be chosen. The submenu now offers the uninstalled voices in the call's language under Download, with their sizes. Choosing one downloads it off the main thread, shows its progress, and switches the call to it once it is installed; a failure shows as a control error. Signed-off-by: John Tennant <jtennant@block.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
🤖 Folded into #416 for review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The menu bar's voice submenu listed only installed Siri voices. To try another voice you had to download it with
berd-call voices downloadfirst, so the menu never showed what else was available.The submenu now ends with a Download submenu listing the voices in the call's language that aren't installed, each with its size (for example,
Damon (325 MB)). Choosing one:Downloading Damon…at the top of the menu and in place of its entry. Other downloads wait until it finishes.If the download fails, the error shows as a control error, the way other menu errors do. Voices in other languages, and removing voices, are out of scope.
Related issue
None.
Testing