Repository navigation
berd-call: name code-named Siri voices from their installed asset - #408
Closed
johnmatthewtennant wants to merge 1 commit into
Closed
johnmatthewtennant wants to merge 1 commit into
johnmatthewtennant wants to merge 1 commit into
Conversation
A voice whose catalog name is a code, such as en-US-F, now takes its display name from the build paths in its installed asset's Info.plist (.../assets/zack_v2_dual_prompt_with_fallback/p2a is Zack). The known names and "Siri Voice N" remain the fallbacks. Signed-off-by: John Tennant <jtennant@block.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
🤖 Folded into #416 for review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Siri voices whose catalog name is a code (
en-US-F,en-US-G) got human names in #401 from a hardcoded table. Their real names live in the installed asset: the build paths in itsInfo.plistname a build directory such as.../assets/zack_v2_dual_prompt_with_fallback/p2a(Zack) or.../assets/gigi_test_2/assets/device(Gigi).The voice catalog now reads those paths from each installed voice's asset and takes the name from them. To keep the result safe across macOS releases:
assets/with more path below it, whose first word is all letters.When the asset is missing, unreadable or ambiguous, the name falls back as before: first to #401's names, then to Siri and the name macOS shows (
Siri Voice 3).Related issue
None.
Testing
en-US-Fanden-US-Gas Zack and Gigi: with berd-call: show names for code-named Siri voices #401's fallback names removed from the build,berd-call voices liststill shows both names, read from their assets. With the change as committed the list is unchanged from before it, and every other code-named voice is stillSiri Voice N.Siri Voice N.en-US-F_5028, leaf folders, single letters and leading digits.