Repository navigation
berd-call: abort a voice change without waiting on the provider - #410
Closed
johnmatthewtennant wants to merge 2 commits into
Closed
johnmatthewtennant wants to merge 2 commits into
johnmatthewtennant wants to merge 2 commits into
Conversation
Rolling back a Spokesperson voice change blocked the call until OpenAI confirmed the cutover's input clear, and stalled the menu bar when that confirmation was slow. Abandon the cutover immediately instead and attribute its late confirmation by send order, so it can neither complete a later reset nor report a stale cutover result. Retire the candidate runtime in the background. Signed-off-by: John Tennant <jtennant@block.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Now that aborting a cutover no longer waits for the worker, the frames a rolled-back voice change replays could reach the provider before the cutover's clear and be discarded with it. Send cutover commands on the input queue, like resets, so they stay in order with the audio they clear. Signed-off-by: John Tennant <jtennant@block.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
🤖 Folded into #416 for review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changing the Spokesperson's voice during a realtime call could freeze the call for up to five seconds when the change was rolled back. Aborting the change waited for OpenAI to confirm that the cutover's input clear had been applied, blocking the call's control loop and the menu bar. A late confirmation could also be mistaken for a later input reset's, and an aborted cutover reported a result after the caller had already moved on.
Aborting now returns at once. The cutover's clear stays in flight, and its confirmation is matched by send order, so it can neither complete a later reset nor report a cutover result. A clear the provider never confirms still ends the session as before. Cutover commands now share the input queue with audio and resets, so input replayed after an abort always follows the cutover's clear. The unused candidate runtime shuts down in the background, and an input reset is accepted while a cutover is pending.
Related issue
None.
Testing