Repository navigation
berd-call: answer input controls still clearing when a session ends - #413
Closed
johnmatthewtennant wants to merge 1 commit into
Closed
johnmatthewtennant wants to merge 1 commit into
johnmatthewtennant wants to merge 1 commit into
Conversation
A mute or input reset waits to be acknowledged until the provider has cleared its input. When the host shut the session down, or closed its input, while a clear was outstanding, the session exited without ever answering those controls. Wait for the outstanding clears, which the runtime settles within its acknowledgement timeout, and answer them before the session ends. Signed-off-by: John Tennant <jtennant@block.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
🤖 Folded into #416 for review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In a realtime Berd Call, muting the microphone or resetting input is acknowledged only after the provider confirms it has cleared its input buffer. If the call ended while a clear was outstanding, the session exited without answering those controls, so a caller waiting on
input_reset_appliedorinput_mute_appliednever got a reply.The session now waits for its outstanding clears and answers them in order before it shuts down or finishes after its input closes. The runtime already settles every clear within its acknowledgement timeout, so the wait is bounded. A clear that fails ends the session with that error, as it does mid-call.
Related issue
None.
Testing
input_reset_appliedtheninput_mute_applied, before the session exits. Before the change the session exited with neither.