Repository navigation
Conversation
Settings saves provider keys through a short-lived goose-acp, but goose caches secrets per process, so the long-lived agent worker kept failing with "Configuration value not found" until Buzz restarted. After a save, send the shared worker goose's existing providers/inventory/refresh, which clears its secret cache and bumps its config generation. Shared API-key providers are keyed by that generation, so sessions build a provider with the new key on their next call; nothing is reopened or interrupted. Refresh is best effort and skipped when no worker is running. Fixes block#1569. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019e7yZchkqtXj3yFgL9wpZr Signed-off-by: Stan <273962421+pepmach@users.noreply.github.com>
pepmach
force-pushed
the
fix/goose-provider-credentials
branch
from
October 22, 2026 22:55
ceeb400 to
41c546f
Compare
pepmach
marked this pull request as ready for review
October 22, 2026 22:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings saves provider keys through a short-lived
goose-acp, while the persistent agent worker caches secrets per process. That worker could keep failing with "Configuration value not found" after a successful save and connection test.After saving provider fields, await Goose's existing
providers/inventory/refreshrequest in the shared worker, if one exists. Goose clears its secret cache and increments its configuration generation; its shared API-key providers are cached against that generation, so the next call rebuilds the provider with the new credentials. Existing sessions continue.Refresh is best effort: a refresh failure does not fail the persisted credential save. The existing request timeout stops an unresponsive worker; other refresh errors are suppressed.
Fixes #1569.
Validation
old → old → new: initial prompt, prompt after a separate credential save, then prompt after inventory refresh. All three prompts used the same worker and ACP session. No real API key or user Keychain was used.Draft acceptance
Desktop Settings flow and human confirmation remain outstanding. Start a Goose worker before configuring its provider, save the provider key in Settings, test the connection, and message the agent again. It should respond without restarting Buzz.
No browser journeys or visual UI changes are included.