Repository navigation
feat(media): name video posters by hash in imeta - #8447
Closed
ngoodger-block wants to merge 1 commit into
Closed
ngoodger-block wants to merge 1 commit into
ngoodger-block wants to merge 1 commit into
Conversation
Desktop and mobile now add `image-x <sha256>` next to a video's `image` poster URL, so the relay can find the poster by hash and restrict who may read it to the channels the video is attached in. Requires a relay that accepts `image-x` (block#8444); older relays reject unknown imeta keys. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Nikolaj Goodger <ngoodger@squareup.com>
🔐 Codex Security Review
|
Contributor
Author
|
🤖 Closing: #8444 now derives poster shares from the existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
#8444 restricts media reads to the channels a file is attached in, but a video's poster is recorded only as a URL (
image <url>), so the relay cannot find it by hash and a private video's poster stays readable to the whole community.What?
Desktop and mobile add
image-x <sha256>beside theimageposter URL, taken from the poster's content-addressed/media/<sha>.<ext>path. Merge only after #8444 is deployed: relays without it reject unknown imeta keys, so video posts with posters would fail.Related issue
Follow-up to #8444.
Testing
Desktop
buildImetaTagsand mobiletoImetaTagunit tests.