Repository navigation
fix: drop idle sessions and other smaller updates - #32
Merged
Merged
Conversation
MCP's logging feature is deprecated (SEP-2577). Ragpi status and errors now go to zerolog instead of only to clients that requested log messages, and parameters that only fed those calls are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Parallel tool calls in one session raced on RequestCount and RequestLog (reported by the race detector). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keep the NewSessionManager call; it sets the global used by TrackSession and starts its cleanup loop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Adds an slog-to-zerolog adapter. SDK output was previously discarded; Info lifecycle lines stay filtered out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Makes rejections inside the SDK (415 Content-Type, 403 Host, 404 session) visible in server logs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Abandoned sessions previously stayed in memory until the next deploy. The app's own session tracking now uses the same timeout instead of 1 hour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bucknalla
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up from the last PR, these are some more minor issues that Claude identified. The only notable one is the idle session issue, which in theory could cause $ problems. Tested locally (re-connects with Claude Code are the main issue, and that worked). Reviewed by Codex too.
From Claude:
/expert/is now logged, including the SDK's own 415, 403 and 404 rejections, which were previously invisible.Session.Logcalls with server-side logging. MCP's logging feature is deprecated (SEP-2577). Ragpi errors now reach the server logs, and parameters that only fed those calls are gone.sessionManagervariable. TheNewSessionManager()call stays, because tool handlers depend on it.