Repository navigation
Quick updates - #347
Merged
Merged
Quick updates#347
Conversation
Discord.Net keeps members fetched by DownloadUsersAsync forever, so every guild that used /ship kept its full member list in memory. The support server is skipped since the Friend badge checks its members.
Cached avatar bitmaps were dropped from the cache without being disposed, and the generated image was never disposed either, so SkiaSharp's native memory only came back whenever the finalizer got to it. Also reuse one HttpClient for avatar downloads.
The cache held up to 1000 full Discord messages for 12 hours each, but only needs the ID and reaction counts. The full message is now fetched once, right before it is posted to the board.
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 1 medium |
🟢 Metrics 5 complexity · 0 duplication
Metric Results Complexity 5 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.