Fix double destructor call in (un)buffered_channel::iterator::operator++#342
Open
eoan-ermine wants to merge 4 commits into
Open
Fix double destructor call in (un)buffered_channel::iterator::operator++#342eoan-ermine wants to merge 4 commits into
eoan-ermine wants to merge 4 commits into
Conversation
increment_() already calls destructor
increment_() already calls destructor
Contributor
Author
|
Oh. There's already #339 . Sorry, didn't notice |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR addresses issue 291 around channel iteration by adjusting iterator element-lifetime handling and adding regression tests to ensure range-for iteration works with non-trivial types (e.g., std::shared_ptr).
Changes:
- Added new regression tests (
test_issue_291) for both buffered and unbuffered channels usingstd::shared_ptr<int>and range-for iteration. - Modified channel iterators to stop explicitly destroying the stored
value_typeinoperator++()(likely to prevent double-destruction / invalid lifetime transitions).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| test/test_unbuffered_channel_post.cpp | Adds a regression test that iterates an unbuffered_channel<std::shared_ptr<int>> via range-for and validates values. |
| test/test_buffered_channel_post.cpp | Adds a matching regression test for buffered_channel<std::shared_ptr<int>>. |
| include/boost/fiber/unbuffered_channel.hpp | Removes explicit destruction of iterator’s in-place value_type on increment. |
| include/boost/fiber/buffered_channel.hpp | Removes explicit destruction of iterator’s in-place value_type on increment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+451
to
+454
| auto it = vec.begin(); | ||
| BOOST_CHECK_EQUAL(256, *(*it)); | ||
| it++; | ||
| BOOST_CHECK_EQUAL(512, *(*it)); |
Comment on lines
+497
to
+500
| auto it = vec.begin(); | ||
| BOOST_CHECK_EQUAL(256, *(*it)); | ||
| it++; | ||
| BOOST_CHECK_EQUAL(512, *(*it)); |
Comment on lines
+490
to
+491
| void test_issue_291() { | ||
| boost::fibers::buffered_channel<std::shared_ptr<int>> chan(16); |
Comment on lines
446
to
449
| iterator & operator++() { | ||
| reinterpret_cast< value_type * >( std::addressof( storage_) )->~value_type(); | ||
| increment_(); | ||
| return * this; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Thank you, slop machine. What do you suggest, call destructor twice or remove destructor call in increment_?
Comment on lines
411
to
414
| iterator & operator++() { | ||
| reinterpret_cast< value_type * >( std::addressof( storage_) )->~value_type(); | ||
| increment_(); | ||
| return * this; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
increment_() already calls destructor
Closes #291