Skip to content

content: add approve.script.already_has_passkey (from chitin #63) - #70

Merged
bdelanghe merged 1 commit into
mainfrom
approve-already-has-passkey
Oct 27, 2026
Merged

bdelanghe merged 1 commit into
mainfrom
approve-already-has-passkey

Conversation

@bdelanghe

Copy link
Copy Markdown
Contributor

Closes #69

Adds approve.script.already_has_passkey to content/strings.json, the reason the chitin approve page shows when WebAuthn raises InvalidStateError because the device already holds a synced passkey. The token, its text and its description are copied from bdelanghe/chitin#63, which landed after #66 copied the approve group. chitin's pin to brand main needs it: without it, chitin's every_token_is_used_and_every_used_key_is_a_token test fails.

  1. Independent PR — no bundled or speculative changes
    • Verified: one token added to content/strings.json (approve.script group), nothing else
  2. Changed codepaths verified — targeted unit and full integration tests
    • Verified: node tools/content.mjs passes (copy lint clean); chitin-approve's flake check against this file is the downstream test
  3. Root cause identified — every failure traced to source
  4. No duplication — refactoring preferred over copy/paste
    • Brand is the one home for the text; chitin re-vendors it from here by pin, so there's no second hand-maintained copy
  5. No unrelated changes — housekeeping isolated to its own branch
    • N/A

🤖 Generated with Claude Code

https://claude.ai/code/session_0117AAnztxdG2tNqQSCsQB7q

bdelanghe/chitin#63 gave the approve page a reason for WebAuthn
InvalidStateError (the device already holds a passkey synced through iCloud
Keychain) as the token script.already_has_passkey. It landed after #66 copied
the approve group, so the shared file lacked it and chitin's pin to brand
main fails its every-used-key-is-a-token test. Same text and description as
chitin #63.

Closes #69

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117AAnztxdG2tNqQSCsQB7q
@bdelanghe
bdelanghe merged commit 7ad729b into main Oct 27, 2026
10 of 11 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Front Desk Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

content: add approve.script.already_has_passkey (from chitin #63)

1 participant