Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Videos with GPS in their embedded XMP had no position (#1260). ffprobe only exposes that XMP with
-export_xmp 1, and up to ffprobe 4.3 the flag aborts the probe for any container whose demuxer doesn't know it (4.4+ only warns). SoloadVideoMetadatanow runs a second probe with the flag when the first one reports the mov/mp4 demuxer, and passes the XMP through the existingmapGPS, same parsing as the photo branch and XMP sidecars (sidecars still win). That is one extra ffprobe run per mp4/mov at index time. Only GPS is taken from the embedded XMP on purpose: mapping everything would also change the creation dates of videos that carry Adobe XMP.Added a test that appends an XMP uuid box with GPS to a copy of
video.mp4at runtime (no new binary fixture); it failed before the fix. The MetadataLoader, DiskManagerWorker and ffmpeg video worker specs pass with it (120 passing).Two notes. It reads the standard
exif:GPSLatitude/exif:GPSLongitudeXMP tags (what exiftool writes); theXMP-crdnamespace from the issue is non-standard and I had no sample for it. And the folder overview map is fed through thephotosOnlypipe, so after a reindex the video shows its position in the lightbox info panel and mini map, but not yet on the overview map. Happy to add videos there in a follow-up if you want them.