use rb_ary_entry in yajl_encode_part to avoid stale RARRAY_PTR#235
Open
jmestwa-coder wants to merge 1 commit into
Open
use rb_ary_entry in yajl_encode_part to avoid stale RARRAY_PTR#235jmestwa-coder wants to merge 1 commit into
jmestwa-coder wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed the T_ARRAY case in yajl_encode_part caches
VALUE *ptr = RARRAY_PTR(obj)and then walksptr[idx]. But each element can run Ruby (a member's to_s/to_json, or the on_progress block during a buffer flush); if that grows the same array its backing store is reallocated andptrdangles, so the nextptr[idx]reads freed memory and segfaults. Reading throughrb_ary_entry(obj, idx)hits the live buffer each pass and is bounds-checked.