Repository navigation
feat(diagnostics): add isolated whisper Vulkan and CPU probes - #586
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#580 records four abnormal exits during Vulkan transcription on a Radeon 780M, while #581 reports that CPU mode works. The bundle has no native stack, selected Vulkan device or AMD driver version, so it cannot identify the underlying failure.
Add an explicit Whisper diagnostic to the export dialog on Windows/Linux. Users can compare an installed model on Vulkan/CPU and toggle VAD using the bundled short speech sample. Each run loads the addon in a disposable utility process, with cancellation and a three-minute deadline, so native diagnostic crashes leave the application available to export evidence. The last six reports include the addon, execution phase, native device messages, stderr tail and exit classification in
addon.json; Windows adapter driver versions are included ingpu.json. Native text in JSON snapshots is sanitized before export.This adds diagnostic isolation only. Normal transcription, acceleration settings and crash-breaker policy are unchanged; it does not claim to fix the Radeon driver/backend failure or add automatic CPU retries. A completed short-sample test is not a guarantee for all inputs. Windows exit-code precision loss remains explicitly marked and can be correlated with crash events/dumps.
Validation:
yarn typecheck,yarn check:i18n,yarn buildyarn test:gpu-enumerationplus the AMD driver propagation testyarn test:crash(22 suites), including report redaction/export and diagnostic lifecycle coverageyarn jest --runInBand renderer/components/__tests__/DiagnosticsDialog.test.tsx(10 tests)node scripts/crash/smoke.mjs whisper-probe: real Electron/native access-violation on macOS arm64; main process survives and a subsequent diagnostic runsRefs #580, #581.