Repository navigation
fix(p3-shim): strict parsing for http path-with-query - #2262
Merged
Merged
Conversation
andreiltd
force-pushed
the
http-req-fix
branch
from
October 15, 2026 09:40
226fbfe to
40334d9
Compare
andreiltd
changed the title
vados-cosmonic
approved these changes
Oct 15, 2026
vados-cosmonic
left a comment
vados-cosmonic
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 🚀
Thanks for the update here @andreiltd , going to look at the failing extended test, I wonder if the test itself will need to be updated.
Collaborator
|
Nope it looks like the failure is related to moonbit's build... might have to make a separate fix for that and then rebase this |
This is mirroring fixes from wasmtime, see: - bytecodealliance/wasmtime#14727 - WebAssembly/wasi-testsuite#293
vados-cosmonic
force-pushed
the
http-req-fix
branch
from
October 15, 2026 14:13
40334d9 to
63f4a14
Compare
vados-cosmonic
enabled auto-merge
October 15, 2026 14:14
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 15, 2026
Collaborator
|
🎉 The code in this PR was made available in the following release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mirroring fixes from wasmtime, see:
http-request.rstest WebAssembly/wasi-testsuite#293