Repository navigation
Remove rust-precision dependency - #334
Merged
Merged
Conversation
fitzgen
reviewed
Sep 23, 2026
fitzgen
left a comment
fitzgen
left a comment
Member
There was a problem hiding this comment.
Thanks! A suggestion and a question below
theotherjimmy
force-pushed
the
remove-precision
branch
2 times, most recently
from
September 28, 2026 14:46
7441c3e to
19a10cb
Compare
Since we only use the cpu counters from rust-precision, and it's stale I've elected to add support for s390x by removing the denpendency. Signed-off-by: Jimmy Brisson <jbrisson@linux.ibm.com>
theotherjimmy
force-pushed
the
remove-precision
branch
2 times, most recently
from
September 28, 2026 14:47
19a10cb to
14b1843
Compare
Contributor
Author
|
The current changes to support macos made things a bit weird on the rebase. I think it's working again, and should have taken your review into account. |
Member
|
Sorry for the churn with the macos change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we only use the cpu counters from rust-precision, and it's stale I've elected to add support for s390x by removing the denpendency.