Remove async feature of wit-bindgen-rust-macros#1595
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Apr 17, 2026
Merged
Remove async feature of wit-bindgen-rust-macros#1595alexcrichton merged 1 commit intobytecodealliance:mainfrom
async feature of wit-bindgen-rust-macros#1595alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
This removes the `async` feature which is purely used for an error message and that's it. While the error message is useful the way that the feature is activated results in an unfortunate interaction with Cargo dependencies and how lock files are generated. Notably the conditional `a?/b` syntax means that even when a Cargo feature is disabled the full dependency tree shows up in lock files (for now). The dependency tree of `wit-bindgen-rust-macros` is quite large, which is why it's an optional feature, so this is undesirable.
dicej
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
asyncfeature which is purely used for an error message and that's it. While the error message is useful the way that the feature is activated results in an unfortunate interaction with Cargo dependencies and how lock files are generated. Notably the conditionala?/bsyntax means that even when a Cargo feature is disabled the full dependency tree shows up in lock files (for now). The dependency tree ofwit-bindgen-rust-macrosis quite large, which is why it's an optional feature, so this is undesirable.