[petebachant]

No description provided.

[Copilot]

Pull request overview

This PR addresses failures during new-project setup when using a default ck:// DVC remote, and improves production observability for backend latency and 5xx errors (Grafana + Prometheus buckets).

Changes:

• Register ck:// support early in-process and run DVC via python -m calkit dvc to ensure the scheme is available in subprocesses.
• Make project-creation flow more robust against DB uniqueness races and add a regression test for ck:// DVC config + CLI operations.
• Improve API monitoring by extending latency histogram buckets and enhancing the FastAPI Grafana dashboard with a dedicated 500s log panel.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
config/grafana/provisioning/dashboards/fastapi.json	Reformats panels and adds a Loki-backed “Backend 500s” log panel; adjusts layout accordingly.
backend/uv.lock	Updates lockfile for calkit-python==0.41.24 and pulls in new dependency set (notably DVC extras).
backend/pyproject.toml	Bumps calkit-python dependency to 0.41.24.
backend/app/tests/test_dvc.py	Adds regression test ensuring ck:// scheme works for both config validation and DVC CLI.
backend/app/projects.py	Handles concurrent insert race when caching GitHub collaborator permissions (IntegrityError).
backend/app/main.py	Extends Prometheus latency histogram buckets for better tail visibility.
backend/app/dvc.py	Registers ck:// scheme at import time and introduces run_dvc_command wrapper using calkit dvc.
backend/app/api/routes/projects/core.py	Switches DVC subprocess calls to run_dvc_command and adds rollback/delete cleanup on setup failures.

Suppressed comments (4)

backend/app/api/routes/projects/core.py:593

• run_dvc_command(["config", ...]) return code is ignored. If this fails, we’ll still commit/push and leave the repo in an unexpected state. Using check=True here would make failures raise and be handled by the outer try/except.

            logger.info("Enabling DVC autostage")
            run_dvc_command(
                ["config", "core.autostage", "true"],
                wdir=str(repo.working_dir),
            )

backend/app/api/routes/projects/core.py:3274

• dvc init here is executed without check=True, so a failure will be ignored and the subsequent dvc add will fail with a less-direct error. Consider checking init to fail fast when DVC can’t initialize in this repo.

    if not os.path.isdir(os.path.join(repo.working_dir, ".dvc")):
        logger.info("Calling dvc init since .dvc directory is missing")
        run_dvc_command(["init"], wdir=str(repo.working_dir))

backend/app/api/routes/projects/core.py:3697

• dvc init here is executed without check=True, so a failure will be ignored and the subsequent dvc add will fail with a less-direct error. Consider checking init to fail fast when DVC can’t initialize in this repo.

        if not os.path.isdir(os.path.join(repo.working_dir, ".dvc")):
            logger.info("Calling dvc init since .dvc directory is missing")
            run_dvc_command(["init"], wdir=str(repo.working_dir))

backend/app/api/routes/projects/core.py:2225

• dvc init here is executed without check=True, so a failure will be ignored and the subsequent dvc add will fail with a less-direct error. Making init checked gives a clearer failure mode and avoids proceeding when DVC isn’t initialized.

        if not os.path.isdir(os.path.join(repo.working_dir, ".dvc")):
            logger.info("Calling dvc init since .dvc directory is missing")
            run_dvc_command(["init"], wdir=str(repo.working_dir))

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.