Initial tests for alta_open_lambda#7
Draft
camdroid wants to merge 1 commit into
Draft
Conversation
With the upcoming Neon webhook deprecation, we need for the alta-open-update lambda to be able to handle both the legacy and the new webhook format. Roughly, this is what the deprecation strategy looks like: * Enable new Neon webhooks (already done) * Update lambda to work on both styles of payload (new or legacy) * Monitor results, ensure that there are no errors and that the new webhooks have the correct behavior. * Disable legacy webhooks (one at a time) in Neon. * Monitor results, ensure that operations are happening as expected (accounts are actually being created, etc.) * Update lambda to throw an error for legacy webhook calls, without updating Alta. * (Eventually) Remove code for handling legacy Neon webhooks. To help with the first step of updating the lambda, I want to write a test suite to capture the current behavior. The point of this isn't to catch any new bugs, just to verify what's already happening in the lambda. Once we can show what behavior is currently happening under the legacy webhooks, we can start adding in the new webhook formats and ensuring that the tests work with those, too, using the `legacy` flag if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the upcoming Neon webhook deprecation, we need for the
alta-open-update lambda to be able to handle both the legacy and the new
webhook format. Roughly, this is what the deprecation strategy looks
like:
webhooks have the correct behavior.
(accounts are actually being created, etc.)
updating Alta.
To help with the first step of updating the lambda, I want to write a
test suite to capture the current behavior. The point of this isn't to
catch any new bugs, just to verify what's already happening in the
lambda.
Once we can show what behavior is currently happening under the legacy
webhooks, we can start adding in the new webhook formats and ensuring
that the tests work with those, too, using the
legacyflag if needed.Stack created with GitHub Stacks CLI • Give Feedback 💬