[cadejacobson]

Proposed Commit Message

fix(azure): ensure ephemeral networking uses primary NIC

When ephemeral networking is brought up in Azure, the selected interface
(`iface`) is `None` under certain conditions. This change introduces 
a helper function `find_primary_nic()` which uses 
`net.find_candidate_nics()` to determine and select the system's primary 
network interface if one is not explicitly set.

Additional improvements:
- Log the MAC address and driver of the selected NIC for easier debugging.
- Ensure the DHCP retry loop updates `iface` to the current primary NIC before
  retrying to obtain a lease.

Fixes 6558 

Updated Output

After these changes, the output for creating a VM reads:

2025-11-04 21:47:15,765 - azure.py[DEBUG]: Bringing up ephemeral networking with iface=eth0 mac=7c:1e:52:e8:55:f9 driver=hv_netvsc : [('lo', '00:00:00:00:00:00', None, None), ('eth1', '7c:1e:52:e8:5e:80', 'hv_netvsc', '0x3'), ('eth0', '7c:1e:52:e8:55:f9', 'hv_netvsc', '0x3')]

Merge type

• Squash merge using "Proposed Commit Message"

Fixes #6558

[holmanb]

Thanks for the contribution.

Please link this to the bug that this is supposed to fix. If none exists, one should be created containing full context (logs where this happened with any other relevant details).

When ephemeral networking is brought up in Azure, the selected interface
(iface) may be None under certain conditions.

Which conditions? Were those conditions reproducable and was this demonstrated to fix the problem when that occurs?

[cadejacobson]

Thanks for the contribution.

Please link this to the bug that this is supposed to fix. If none exists, one should be created containing full context (logs where this happened with any other relevant details).

When ephemeral networking is brought up in Azure, the selected interface
(iface) may be None under certain conditions.

Which conditions? Were those conditions reproducable and was this demonstrated to fix the problem when that occurs?

Sounds good! I will get a bug made with the relevant context. For a very short overview here, three out of four calls to the _setup_ephemeral_networking() function do not provide an explicit interface in the parameters so it defaults to None. When we enter the ephemeral networking function and log which interface we are bringing up networking on, the log is simply Bringing up ephemeral networking with iface=None. I will get more verbose logs and these conditions mapped out in the issue and link it back here!

Thank you for the guidance 😁 this is my first PR to Cloud-init, so I left this as a draft while I get the required materials compiled for a proper review.

[holmanb]

@cadejacobson Thanks for filing the bug. No worries - and welcome!

[cadejacobson]

@holmanb I have gotten this work to its final state. Could I please have you run the pipelines one more time to verify we do not need minor changes? Thanks so much!

[holmanb]

It looks like this is waiting for updates per the latest review, so I'll hold off on reviewing it for now.

[cjp256]

Changes look great, a few minor and optional nitpicks. Integration test results (internal) look great. The one thing I would like to see is a test covering update_primary_nic=True where the interface does change.

[cjp256]

minor changes to test and LGTM!

[cjp256]

thanks!

[mentos1386]

Hi all, when can we expect this to be merged/released?

[holmanb]

Thanks for this @cadejacobson. One nit, otherwise this looks good to me.

[cadejacobson]

Hi all, when can we expect this to be merged/released?
@mentos1386

This is ready for merge on our end! I got the feedback from @holmanb addressed.