[blackboxsw]

• I have signed the CLA: https://ubuntu.com/legal/contributors
• I have included a comprehensive commit message using the guide below
• I have added unit tests to cover the new behavior under tests/unittests/
  • Test files should map to source files i.e. a source file cloudinit/example.py should be tested by tests/unittests/test_example.py
  • Run unit tests with tox -e py3
• I have kept the change small, avoiding unnecessary whitespace or non-functional changes.

Proposed Commit Messages

* tests: add MAAS test for kernel reading datasource from kernel command line

* chore: drop ds-identify support for MAAS

Fixes PALS-1837

Additional Context

Test Steps

Merge type

• Squash merge using "Proposed Commit Message"
• Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

[github-actions]

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging blackboxsw, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag blackboxsw to reopen it.)

[holmanb]

This might work, but it lays a trap for future developers.

This injects a global variable into the script by way of a mocked function.

What happens if no mock is provided?

[holmanb]

Perhaps we can make use of the file sourced in get_environment instead?

[blackboxsw]

Per your suggestion, kooks like we can write into ds-identify-env file directly. I provided a mechanism to set that to /ds_identify-env and write it with files to allow sourcing env vars we want to leverage during main() invocation.

[holmanb]

I wouldn't put an internal jira ticket in the commit history - it isn't generally useful. Linking to it from the PR description is fine. I would also modify the commit message to indicate that the current code is broken - as it is this reads as if ds-identify is loosing MAAS support, which it isn't.

Once the commit message is updated this looks good to me!

[holmanb]

nice, that's slick!