Repository navigation
feat: portfolio v2 transfer - #2785
Merged
Merged
Conversation
rukmini-basu-da
marked this pull request as ready for review
October 23, 2026 14:22
rukmini-basu-da
force-pushed
the
rukmini/core-tx-parser-support-tsv2
branch
2 times, most recently
from
October 26, 2026 12:50
4532bd3 to
d9ef0fc
Compare
rukmini-basu-da
marked this pull request as draft
October 26, 2026 12:50
rukmini-basu-da
force-pushed
the
rukmini/portfolio-v2-transfer
branch
from
October 26, 2026 14:33
cf5e66f to
361fc9a
Compare
rukmini-basu-da
force-pushed
the
rukmini/portfolio-v2-transfer
branch
from
October 26, 2026 15:13
2250e5e to
b2bd549
Compare
rukmini-basu-da
marked this pull request as ready for review
October 26, 2026 16:20
fayi-da
requested changes
Oct 27, 2026
fayi-da
left a comment
fayi-da
left a comment
Contributor
There was a problem hiding this comment.
- Are pending offers remaining the same? No special v2 treatment?
- I noticed the sdk doesnt pass along all the transfer params, e.g memo or expDate. Why? This makes those fields no-ops for v2 transfers. User will set them but it'll never get carried over
- I think we need to extend the e2e tests here to have both v1 and v2 tranfers intertwined
fayi-da
reviewed
Oct 27, 2026
Contributor
Author
Currently, the v1 and v2 transfer offers appear, but we need to make some changes for the v2 allocations (this is part of the allocations subtask) |
rukmini-basu-da
force-pushed
the
rukmini/portfolio-v2-transfer
branch
from
October 27, 2026 13:39
6c09080 to
b84fbe6
Compare
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> fix typos and refactor Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> add test Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> fix reason for v2 event and mergesplit for self transfers Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> fix reason for v2 event and mergesplit for self transfers Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> parse reason from label.reason and label.meta.values Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> move tsmock Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> split out v1 only tests Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> cleanup Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> cleanup Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> add more specific assertions Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> fix allocation lifecycle check Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> v2 events should inherit v1 tokenStandardChoice Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> fix net transfer amount Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> fix Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> fix conflict Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> fix conflict Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> fix conflict Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
rukmini-basu-da
force-pushed
the
rukmini/portfolio-v2-transfer
branch
from
October 27, 2026 14:07
b84fbe6 to
bfa9f6e
Compare
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
fayi-da
requested changes
Oct 28, 2026
rukmini-basu-da
enabled auto-merge (squash)
October 28, 2026 14:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested a transfer from testparty5 to testparty6 of 10 Amulet:
Test transfer screen for v2 as
testparty5::1220ea23db24749934e015095e78915698e0d4edbd7335bd685f069e2e38e592b1fe:transfer summary screen:
Transfer offer screen (outgoing as testparty5):
Transfer offer screen (incoming as testparty6)
Transaction history (testparty6):