Repository navigation
feat(dapp-sdk): allow renaming saved remote wallets - #2816
Merged
pascalhonegger-da merged 3 commits intoOct 28, 2026
Merged
pascalhonegger-da merged 3 commits into
pascalhonegger-da merged 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The rename flow mishandles Enter and Escape during IME composition and fails to restore focus after saving or cancelling, disrupting text entry and keyboard and screen-reader navigation.
2 open issues
What changed in this PR
Adds renaming for saved custom remote wallets in the wallet picker and preserves the selected label when the dApp SDK reconnects.
Changes:
- Adds inline rename, save, cancel, and reset controls, with URLs and monograms for renamed wallets.
- Keeps restored custom gateways editable and refreshes their adapter names on selection.
- Adds component, SDK, and end-to-end coverage, plus a renamed-wallet story.
| File | Description |
|---|---|
sdk/dapp-sdk/src/sdk.ts |
Preserves custom gateway classification and refreshes selected names. |
sdk/dapp-sdk/src/sdk.test.ts |
Tests renamed gateway reconnection and restored gateway handling. |
examples/ping/tests/walletpicker.spec.ts |
Tests renaming, cancellation, reset, and persistence end to end. |
core/wallet-ui-components/src/windows/wallet-picker.stories.ts |
Adds a renamed custom gateway example. |
core/wallet-ui-components/src/components/wallet-picker.ts |
Implements rename controls, label persistence, and shared icons. |
core/wallet-ui-components/src/components/wallet-picker.test.ts |
Tests rename behavior and wallet icon rendering. |
core/wallet-test-utils/src/wallet-gateway.ts |
Allows custom picker interactions during test connections. |
Review effort: Balanced
pascalhonegger-da
force-pushed
the
2553-allow-renaming-saved-remote-wallets-in-wallet-picker
branch
from
October 28, 2026 13:10
ce8f87b to
79f090c
Compare
pascalhonegger-da
marked this pull request as ready for review
October 28, 2026 13:10
Signed-off-by: Pascal Honegger <pascal.honegger@digitalasset.com>
…ne place Signed-off-by: Pascal Honegger <pascal.honegger@digitalasset.com>
pascalhonegger-da
force-pushed
the
2553-allow-renaming-saved-remote-wallets-in-wallet-picker
branch
from
October 28, 2026 13:39
79f090c to
8cc9cbe
Compare
mjuchli-da
approved these changes
Oct 28, 2026
pascalhonegger-da
deleted the
2553-allow-renaming-saved-remote-wallets-in-wallet-picker
branch
October 28, 2026 14:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-10-28.at.13.37.55.mov