CMF Viewer: detail window improvements#1
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the CMF Viewer “Details” UI by replacing the previous mesh-details tabbed window with a new collapsible detail window that presents a file hierarchy tree (top) and the selected item’s detailed data (bottom), and refactors that UI into a separate component.
Changes:
- Replaces
UIRenderer::MeshDetailsWindowwith a standaloneUIDetailWindowcomponent and updates renderer integration. - Adds the new hierarchy/detail rendering implementation (
uiDetailWindow.{h,cpp}) including navigation links and additional data views (e.g., curve keys/values, index-buffer area column). - Adjusts supporting state/data APIs (e.g.,
CmfContent::Index()becomesconst,StateCollection::Clear()now fires callbacks).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| src/viewer/rendering/uiRenderer.h | Integrates the new UIDetailWindow member and removes old details-window declarations/state. |
| src/viewer/rendering/uiRenderer.cpp | Routes UI rendering through UIDetailWindow::Render() and removes the previous details-window implementation. |
| src/viewer/rendering/uiRenderer_template_impl.h | Removes the old BuildAttributes helper (moved/obsolete with the refactor). |
| src/viewer/rendering/uiDetailWindow.h | Declares the new detail window component and its selection model. |
| src/viewer/rendering/uiDetailWindow.cpp | Implements the new hierarchy + detail rendering and navigation logic. |
| src/viewer/data/cmfcontent.h | Makes Index() const and marks decompression cache mutable. |
| src/viewer/data/cmfcontent.cpp | Updates Index() definition to match const signature. |
| src/viewer/appState_template_impl.h | Ensures StateCollection::Clear() triggers callbacks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ccp-intern
reviewed
Jun 22, 2026
ccp-intern
reviewed
Jun 22, 2026
ccp-intern
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the look of the detail window. It now has a hierarchy tree view on top and detailed info on the bottom.