Skip to content

CMF Viewer: detail window improvements#1

Merged
filipppavlov merged 34 commits into
mainfrom
detail-window
Jun 23, 2026
Merged

CMF Viewer: detail window improvements#1
filipppavlov merged 34 commits into
mainfrom
detail-window

Conversation

@filipppavlov

Copy link
Copy Markdown
Contributor

Change the look of the detail window. It now has a hierarchy tree view on top and detailed info on the bottom.

608462289-5f1e3383-449d-4ed9-8bb3-a03f454d7f96
  • Show contents of all loaded files
  • Use single clicks to navigate instead of double-clicking, and use a consistent "hyperlink" style for clickable fields
  • Show curve data (keys, values)
  • Remove filtering in some of the tables
  • Add an area column to the index buffer view
  • Make the detail window collapsible and collapsed on startup
  • Move the detail window code into a separate file

Copilot AI review requested due to automatic review settings June 22, 2026 09:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CMF Viewer “Details” UI by replacing the previous mesh-details tabbed window with a new collapsible detail window that presents a file hierarchy tree (top) and the selected item’s detailed data (bottom), and refactors that UI into a separate component.

Changes:

  • Replaces UIRenderer::MeshDetailsWindow with a standalone UIDetailWindow component and updates renderer integration.
  • Adds the new hierarchy/detail rendering implementation (uiDetailWindow.{h,cpp}) including navigation links and additional data views (e.g., curve keys/values, index-buffer area column).
  • Adjusts supporting state/data APIs (e.g., CmfContent::Index() becomes const, StateCollection::Clear() now fires callbacks).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
src/viewer/rendering/uiRenderer.h Integrates the new UIDetailWindow member and removes old details-window declarations/state.
src/viewer/rendering/uiRenderer.cpp Routes UI rendering through UIDetailWindow::Render() and removes the previous details-window implementation.
src/viewer/rendering/uiRenderer_template_impl.h Removes the old BuildAttributes helper (moved/obsolete with the refactor).
src/viewer/rendering/uiDetailWindow.h Declares the new detail window component and its selection model.
src/viewer/rendering/uiDetailWindow.cpp Implements the new hierarchy + detail rendering and navigation logic.
src/viewer/data/cmfcontent.h Makes Index() const and marks decompression cache mutable.
src/viewer/data/cmfcontent.cpp Updates Index() definition to match const signature.
src/viewer/appState_template_impl.h Ensures StateCollection::Clear() triggers callbacks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/viewer/rendering/uiDetailWindow.cpp
Comment thread src/viewer/rendering/uiDetailWindow.cpp
Comment thread src/viewer/rendering/uiDetailWindow.cpp
Comment thread src/viewer/rendering/uiDetailWindow.cpp
Comment thread src/viewer/rendering/uiDetailWindow.cpp
Comment thread src/viewer/rendering/uiDetailWindow.cpp
Comment thread src/viewer/rendering/uiDetailWindow.cpp
Comment thread src/viewer/rendering/uiDetailWindow.cpp
Comment thread src/viewer/rendering/uiDetailWindow.cpp
Comment thread src/viewer/rendering/uiRenderer.cpp Outdated
Comment thread src/viewer/appState_template_impl.h Outdated
Comment thread src/viewer/rendering/uiDetailWindow.cpp Outdated
@filipppavlov filipppavlov merged commit 8dfecb4 into main Jun 23, 2026
13 checks passed
@filipppavlov filipppavlov deleted the detail-window branch June 23, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants