Apply changes to TC projects from carbon-template#3
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the TeamCity Kotlin DSL for the Windows and macOS build configurations to align with the carbon-template settings, primarily around artifact publishing, Visual Studio environment bootstrapping, VCS triggering, and GitHub authentication parameters.
Changes:
- Publish build outputs as a named artifact and adjust artifact rules.
- Parameterize the Visual Studio dev environment bootstrap path on Windows.
- Update VCS trigger behavior (Windows) and switch GitHub auth token parameter name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.teamcity/Windows/Project.kt |
Updates artifact rules, Windows VS bootstrap command, VCS trigger branch filter, and GitHub token parameter. |
.teamcity/MacOS/Project.kt |
Updates artifact rules and GitHub token parameter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| this.name = buildName | ||
|
|
||
| artifactRules = "%env.CMAKE_INSTALL_PREFIX%" | ||
| artifactRules = "%env.CMAKE_INSTALL_PREFIX% => artifact.zip" |
| name = buildName | ||
|
|
||
| artifactRules = "%env.CMAKE_INSTALL_PREFIX%" | ||
| artifactRules = "%env.CMAKE_INSTALL_PREFIX% => artifact.zip" |
Comment on lines
90
to
93
| REM unfortunately ninja does not find the VS environment otherwise | ||
| REM NB: the exported PATH also contains the location where we installed sentry-cli, e.g. teamcity.agent.work.dir | ||
| call "%%ProgramFiles(x86)%%\Microsoft Visual Studio\2017\BuildTools\Common7\Tools\vsdevcmd.bat" -arch=x64 | ||
| call "%env.VSDEV_BAT_PATH%" -arch=x64 | ||
| echo ##teamcity[setParameter name='env.INCLUDE' value='%%INCLUDE%%'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.