feat: replace abandoned jsr305 with jakarta.annotation-api#124
Conversation
|
|
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
|
@copilot fix: |
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
|
Ah, I see you guys are BUILDING with java 8, jakarta has a baseline of java 17 - modern best practice is to build with a last 2-3 lts version (25, 21, or 17) and target a classfile version of an lts version (earlier than 11 doesn't really makes sense, so 11/17/21 or 25). android doesn't really support newer java features but the android plugin will adapt libraries with desugaring. |
|
i was building locally with jdk 25 and jspecify with class file version 8 and that was working fine, i will double check something about my local setup but i think jspecify "just works" because it is the result of accumulated community experience |
|
ok downgrading that from 3 to 2 seems to be safe for spring boot 3, 4 (and presumably android gradle) projects since gradle depenency resolution fixes it without any special handling in projects that consume this sdk. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #124 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 94 94
Lines 1397 1397
Branches 36 36
======================================
Misses 1397 1397 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
all that is necessary now is to fix the title of the PR - probably it should with either feat: or fix: |
|
🎉 This PR is included in version 1.42.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
fix: #123
Summary
Successfully upgraded from the abandoned
com.google.code.findbugs:jsr305dependency tojakarta.annotation:jakarta.annotation-api:2.1.1. This addresses:All affected Java files have been updated to use
jakarta.annotationimports. The build compiles successfully with no security vulnerabilities detected.